Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(957)

Unified Diff: chrome/browser/ui/views/chooser_content_view_unittest.cc

Issue 2478863003: Fix the Web Bluetooth chooser when it is used on Chrome apps on non-Mac (Closed)
Patch Set: initialize pointer to be nullptr Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/chooser_content_view_unittest.cc
diff --git a/chrome/browser/ui/views/chooser_content_view_unittest.cc b/chrome/browser/ui/views/chooser_content_view_unittest.cc
index f35b3c834c19f1d5b3c20b739cdf00973d8c4ac2..cd8456b167aa669acec2c3dc7b46c4f51fda27ea 100644
--- a/chrome/browser/ui/views/chooser_content_view_unittest.cc
+++ b/chrome/browser/ui/views/chooser_content_view_unittest.cc
@@ -7,6 +7,7 @@
#include <memory>
#include "base/macros.h"
+#include "base/memory/ptr_util.h"
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/chooser_controller/mock_chooser_controller.h"
#include "chrome/grit/generated_resources.h"
@@ -46,9 +47,9 @@ class ChooserContentViewTest : public views::ViewsTestBase {
std::unique_ptr<MockChooserController> mock_chooser_controller(
new MockChooserController(nullptr));
mock_chooser_controller_ = mock_chooser_controller.get();
- mock_table_view_observer_.reset(new MockTableViewObserver());
- chooser_content_view_.reset(new ChooserContentView(
- mock_table_view_observer_.get(), std::move(mock_chooser_controller)));
+ mock_table_view_observer_ = base::MakeUnique<MockTableViewObserver>();
+ chooser_content_view_ = base::MakeUnique<ChooserContentView>(
+ mock_table_view_observer_.get(), std::move(mock_chooser_controller));
table_view_ = chooser_content_view_->table_view_;
ASSERT_TRUE(table_view_);
table_model_ = table_view_->model();
@@ -57,19 +58,19 @@ class ChooserContentViewTest : public views::ViewsTestBase {
ASSERT_TRUE(throbber_);
turn_adapter_off_help_ = chooser_content_view_->turn_adapter_off_help_;
ASSERT_TRUE(turn_adapter_off_help_);
- footnote_link_.reset(chooser_content_view_->CreateFootnoteView());
+ footnote_link_ = chooser_content_view_->footnote_link();
ASSERT_TRUE(footnote_link_);
}
protected:
std::unique_ptr<MockTableViewObserver> mock_table_view_observer_;
std::unique_ptr<ChooserContentView> chooser_content_view_;
- MockChooserController* mock_chooser_controller_;
- views::TableView* table_view_;
- ui::TableModel* table_model_;
- views::Throbber* throbber_;
- views::StyledLabel* turn_adapter_off_help_;
- std::unique_ptr<views::StyledLabel> footnote_link_;
+ MockChooserController* mock_chooser_controller_ = nullptr;
+ views::TableView* table_view_ = nullptr;
+ ui::TableModel* table_model_ = nullptr;
+ views::Throbber* throbber_ = nullptr;
+ views::StyledLabel* turn_adapter_off_help_ = nullptr;
+ views::StyledLabel* footnote_link_ = nullptr;
private:
DISALLOW_COPY_AND_ASSIGN(ChooserContentViewTest);
@@ -629,11 +630,11 @@ TEST_F(ChooserContentViewTest, ClickAdapterOffHelpLink) {
TEST_F(ChooserContentViewTest, ClickRescanLink) {
EXPECT_CALL(*mock_chooser_controller_, RefreshOptions()).Times(1);
chooser_content_view_->StyledLabelLinkClicked(
- footnote_link_.get(), chooser_content_view_->re_scan_text_range_, 0);
+ footnote_link_, chooser_content_view_->re_scan_text_range_, 0);
}
TEST_F(ChooserContentViewTest, ClickGetHelpLink) {
EXPECT_CALL(*mock_chooser_controller_, OpenHelpCenterUrl()).Times(1);
chooser_content_view_->StyledLabelLinkClicked(
- footnote_link_.get(), chooser_content_view_->help_text_range_, 0);
+ footnote_link_, chooser_content_view_->help_text_range_, 0);
}
« no previous file with comments | « chrome/browser/ui/views/chooser_content_view.cc ('k') | chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698