Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3545)

Unified Diff: chrome/browser/ui/views/chooser_content_view.h

Issue 2478863003: Fix the Web Bluetooth chooser when it is used on Chrome apps on non-Mac (Closed)
Patch Set: added code to handle the footnote link pointer ownership Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/chooser_content_view.h
diff --git a/chrome/browser/ui/views/chooser_content_view.h b/chrome/browser/ui/views/chooser_content_view.h
index d277104b45cdfcd26f07dda91a006e27d40b2cf6..d7c8d990fe7e2d26d7b1ee8756f8475e00e3df6c 100644
--- a/chrome/browser/ui/views/chooser_content_view.h
+++ b/chrome/browser/ui/views/chooser_content_view.h
@@ -88,6 +88,10 @@ class ChooserContentView : public views::View,
views::View* table_parent_ = nullptr; // Weak.
views::StyledLabel* turn_adapter_off_help_ = nullptr; // Weak.
views::Throbber* throbber_ = nullptr; // Weak.
+ // |footnote_link_ptr_| will transfer its ownership of the pointer to its
+ // caller when CreateFootnoteView() is called.
+ std::unique_ptr<views::StyledLabel> footnote_link_ptr_;
+ // |footnote_link_| holds a weak pointer of |footnote_link_ptr_|.
views::StyledLabel* footnote_link_ = nullptr; // Weak.
base::string16 help_text_;
base::string16 help_and_scanning_text_;
« no previous file with comments | « no previous file | chrome/browser/ui/views/chooser_content_view.cc » ('j') | chrome/browser/ui/views/chooser_content_view.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698