Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 2478863002: Remove the deprecated ValueSerializer::ReadHeader overload with no context parameter. (Closed)

Created:
4 years, 1 month ago by jbroman
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove the deprecated ValueSerializer::ReadHeader overload with no context parameter. Several weeks have now passed since it was deprecated; Chromium does not call it. BUG=chromium:148757 Committed: https://crrev.com/5d3ce7ea4fa299f8463ee15282fa986b50702cd8 Cr-Commit-Position: refs/heads/master@{#40945}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M include/v8.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/api.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
jbroman
4 years, 1 month ago (2016-11-04 17:05:39 UTC) #4
jochen (gone - plz use gerrit)
lgtm
4 years, 1 month ago (2016-11-12 23:08:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2478863002/1
4 years, 1 month ago (2016-11-13 02:42:48 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-13 03:09:50 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:31:39 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5d3ce7ea4fa299f8463ee15282fa986b50702cd8
Cr-Commit-Position: refs/heads/master@{#40945}

Powered by Google App Engine
This is Rietveld 408576698