Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1796)

Unified Diff: chrome/browser/chromeos/extensions/input_view_browsertest.cc

Issue 247883002: Adds browser test framework for the IME keyboard, and some basic typing tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed nits. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/input_view_browsertest.cc
diff --git a/chrome/browser/chromeos/extensions/input_view_browsertest.cc b/chrome/browser/chromeos/extensions/input_view_browsertest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..fb0c412b114bfbc8bee2713ce96d98b586c64e6d
--- /dev/null
+++ b/chrome/browser/chromeos/extensions/input_view_browsertest.cc
@@ -0,0 +1,90 @@
+/*
+ * Copyright 2014 The Chromium Authors. All rights reserved.
+ * Use of this source code is governed by a BSD-style license that can be
+ * found in the LICENSE file.
+ */
+
+#include "ash/shell.h"
+#include "chrome/browser/chromeos/extensions/virtual_keyboard_browsertest.h"
+#include "chrome/browser/extensions/crx_installer.h"
+#include "chrome/browser/extensions/extension_service.h"
+#include "chrome/browser/extensions/extension_test_notification_observer.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/ui/browser.h"
+#include "chrome/test/base/ui_test_utils.h"
+#include "chromeos/ime/extension_ime_util.h"
+#include "chromeos/ime/input_method_manager.h"
+#include "content/public/browser/render_view_host.h"
+#include "content/public/browser/site_instance.h"
+#include "content/public/browser/web_contents.h"
+#include "content/public/test/browser_test_utils.h"
+#include "extensions/common/constants.h"
+#include "extensions/common/extension.h"
+#include "extensions/common/file_util.h"
+#include "ui/aura/client/aura_constants.h"
+#include "ui/base/ime/input_method.h"
+
+namespace {
+
+const base::FilePath kBaseKeyboardTestFramework =
+ base::FilePath(FILE_PATH_LITERAL("test_base.js"));
+
+const base::FilePath kExtensionName =
+ base::FilePath(FILE_PATH_LITERAL("GoogleKeyboardInput-xkb.crx"));
+
+const base::FilePath kInputViewTestDir =
+ base::FilePath(FILE_PATH_LITERAL("chromeos/virtual_keyboard/inputview/"));
kevers 2014/04/23 13:39:05 Nit: insert blank line before closing brace for na
rsadam 2014/04/23 14:28:53 Done.
+} // namespace
+
+class InputViewBrowserTest : public VirtualKeyboardBrowserTest {
+ public:
+ virtual base::FilePath GetTestDir() OVERRIDE { return kInputViewTestDir; }
+
+ virtual base::FilePath GetBaseFrameWork() OVERRIDE {
+ return kBaseKeyboardTestFramework;
+ }
+
+ // Installs the IME Extension keyboard |kExtensionName|.
+ void InstallIMEExtension() {
+ // Loads extension.
+ ExtensionService* service = browser()->profile()->GetExtensionService();
+ scoped_refptr<extensions::CrxInstaller> installer =
+ extensions::CrxInstaller::CreateSilent(service);
+ base::FilePath path =
+ ui_test_utils::GetTestFilePath(kInputViewTestDir, kExtensionName);
+ ExtensionTestNotificationObserver observer(browser());
+ observer.Watch(chrome::NOTIFICATION_CRX_INSTALLER_DONE,
+ content::Source<extensions::CrxInstaller>(installer.get()));
+ installer->set_allow_silent_install(true);
+ installer->set_creation_flags(extensions::Extension::FROM_WEBSTORE);
+ installer->InstallCrx(path);
+ // Wait for CRX to be installed.
+ observer.Wait();
+ extensionId_ = installer->extension()->id();
+ ASSERT_TRUE(service->GetExtensionById(extensionId_, false));
+
+ // Register extension with IME.
+ chromeos::input_method::InputMethodManager* ime =
+ chromeos::input_method::InputMethodManager::Get();
+ ASSERT_TRUE(ime);
+ std::string id = chromeos::extension_ime_util::GetComponentInputMethodID(
+ extensionId_, "xkb:us::eng");
+ ime->ChangeInputMethod(id);
+ LOG(ERROR) << "Changed input method!";
+ }
+
+ virtual GURL GetURL() OVERRIDE {
+ return GURL("chrome-extension://" + GetKeyboardExtensionId() +
+ "/inputview.html");
+ }
+
+ virtual std::string GetKeyboardExtensionId() OVERRIDE { return extensionId_; }
+
+ private:
+ std::string extensionId_;
+};
+
+IN_PROC_BROWSER_TEST_F(InputViewBrowserTest, TypingTestTest) {
+ InstallIMEExtension();
+ RunTest(base::FilePath(FILE_PATH_LITERAL("typing_test.js")));
+}

Powered by Google App Engine
This is Rietveld 408576698