Adds browser test framework for the IME keyboard, and some basic typing tests.

chrome/browser/chromeos/extensions/input_view_browsertest.cc

Index: chrome/browser/chromeos/extensions/input_view_browsertest.cc
diff --git a/chrome/browser/chromeos/extensions/input_view_browsertest.cc b/chrome/browser/chromeos/extensions/input_view_browsertest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..5ad5542c5356952cecf25c374b257a4035580f1b
--- /dev/null
+++ b/chrome/browser/chromeos/extensions/input_view_browsertest.cc
@@ -0,0 +1,90 @@
+/*
+ * Copyright 2014 The Chromium Authors. All rights reserved.

[Jeffrey Yasskin, 2014/04/28 23:14:50]

http://www.chromium.org/developers/coding-style says:

As of May 2013, the header should look like this: 
// Copyright $YEAR The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

It's generally better to copy that than copy an existing file.

[rsadam, 2014/04/30 17:26:11]

Done.

+ * Use of this source code is governed by a BSD-style license that can be
+ * found in the LICENSE file.
+ */
+
+#include "ash/shell.h"
+#include "chrome/browser/chromeos/extensions/virtual_keyboard_browsertest.h"
+#include "chrome/browser/extensions/crx_installer.h"
+#include "chrome/browser/extensions/extension_service.h"
+#include "chrome/browser/extensions/extension_test_notification_observer.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/ui/browser.h"
+#include "chrome/test/base/ui_test_utils.h"
+#include "chromeos/ime/extension_ime_util.h"
+#include "chromeos/ime/input_method_manager.h"
+#include "content/public/browser/render_view_host.h"
+#include "content/public/browser/site_instance.h"
+#include "content/public/browser/web_contents.h"
+#include "content/public/test/browser_test_utils.h"
+#include "extensions/common/constants.h"
+#include "extensions/common/extension.h"
+#include "extensions/common/file_util.h"
+#include "ui/aura/client/aura_constants.h"
+#include "ui/base/ime/input_method.h"
+
+namespace {
+
+const base::FilePath kBaseKeyboardTestFramework =

[Jeffrey Yasskin, 2014/04/28 23:14:50]

The style guide discourages global/static objects with non-trivial constructors
or destructors. You can store the FILE_PATH_LITERALs here (as const
base::FilePath::CharType[]), but construct the FilePaths inline.

[rsadam, 2014/04/30 17:26:11]

Done.

+    base::FilePath(FILE_PATH_LITERAL("test_base.js"));
+
+const base::FilePath kExtensionName =
+    base::FilePath(FILE_PATH_LITERAL("GoogleKeyboardInput-xkb.crx"));

[Jeffrey Yasskin, 2014/04/28 23:14:50]

It's not great to check in the built .crx. Is its source in the Chrome tree, or
elsewhere? How do you make sure that it stays up to date?

[rsadam, 2014/04/29 23:10:12]

The keyboard's language model is not open source and is built as part of the
official chrome build. There's work in progress to split the layout information
from the layout, however this will not be done until the M37 time frame. For
M36, the IME keyboard will be deployed, and so having the CRX allows at least
basic testing of the keyboard in the mean time.

[Jeffrey Yasskin, 2014/05/02 22:09:36]

Ok.

+
+const base::FilePath kInputViewTestDir =
+    base::FilePath(FILE_PATH_LITERAL("chromeos/virtual_keyboard/inputview/"));
+
+}  // namespace
+
+class InputViewBrowserTest : public VirtualKeyboardBrowserTest {
+ public:
+  virtual base::FilePath GetTestDir() OVERRIDE { return kInputViewTestDir; }
+
+  virtual base::FilePath GetBaseFrameWork() OVERRIDE {
+    return kBaseKeyboardTestFramework;
+  }
+
+  // Installs the IME Extension keyboard |kExtensionName|.
+  void InstallIMEExtension() {
+    // Loads extension.
+    ExtensionService* service = browser()->profile()->GetExtensionService();
+    scoped_refptr<extensions::CrxInstaller> installer =
+        extensions::CrxInstaller::CreateSilent(service);

[Jeffrey Yasskin, 2014/04/28 23:14:50]

It'd be nice to share the common code here with
https://code.google.com/p/chromium/codesearch/#chromium/src/chrome/browser/ex....

[rsadam, 2014/04/29 23:10:12]

The ExtensionBrowserTest doesn't seem to support the set_allow_silent_install
flag - one alternative would be to modify it to make that customizable. Would
this be a better alternative?

[Jeffrey Yasskin, 2014/05/02 22:09:36]

You'd have to refactor it into a free function anyway, since
ExtensionBrowserTest insists you inherit from it to use its helper functions.
InstallOrUpdateExtension() uses a MockAutoConfirmExtensionInstallPrompt to avoid
needing the silent option. I'm not sure how the INSTALL_UI_TYPE_NONE option
works without that, but maybe we don't need all the knobs that have accumulated.

+    base::FilePath path =
+        ui_test_utils::GetTestFilePath(kInputViewTestDir, kExtensionName);
+    ExtensionTestNotificationObserver observer(browser());
+    observer.Watch(chrome::NOTIFICATION_CRX_INSTALLER_DONE,
+                   content::Source<extensions::CrxInstaller>(installer.get()));
+    installer->set_allow_silent_install(true);
+    installer->set_creation_flags(extensions::Extension::FROM_WEBSTORE);
+    installer->InstallCrx(path);
+    // Wait for CRX to be installed.
+    observer.Wait();
+    extensionId_ = installer->extension()->id();
+    ASSERT_TRUE(service->GetExtensionById(extensionId_, false));
+
+    // Register extension with IME.
+    chromeos::input_method::InputMethodManager* ime =
+        chromeos::input_method::InputMethodManager::Get();
+    ASSERT_TRUE(ime);
+    std::string id = chromeos::extension_ime_util::GetComponentInputMethodID(
+        extensionId_, "xkb:us::eng");
+    ime->ChangeInputMethod(id);
+  }
+
+  virtual GURL GetURL() OVERRIDE {
+    return GURL("chrome-extension://" + GetKeyboardExtensionId() +
+                "/inputview.html");
+  }
+
+  virtual std::string GetKeyboardExtensionId() OVERRIDE { return extensionId_; }
+
+ private:
+  std::string extensionId_;
+};
+
+IN_PROC_BROWSER_TEST_F(InputViewBrowserTest, TypingTest) {
+  InstallIMEExtension();
+  RunTest(base::FilePath(FILE_PATH_LITERAL("typing_test.js")));

[Jeffrey Yasskin, 2014/04/28 23:14:50]

It would likely be easier to read this test if the typing_test javascript were
inlined in this .cc file. Since RunTest uses ReadFileToString() to read the file
anyway, it should be straightforward to let it take a string literal.

[rsadam, 2014/04/29 23:10:12]

I have several follow patches that is likely to make the js file very large. My
worry about inlining it would be that it would make reading it harder... We'll
also be adding other tests such as keyset transition tests in M36.

[Jeffrey Yasskin, 2014/05/02 22:09:36]

Hm, ok. I guess the startup overhead of a browser test makes it worthwhile to
combine a bunch into a single RunTest() invocation.

+}