Remove DOMAutomationController::automation_id_

content/public/test/browser_test_utils.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_TEST_BROWSER_TEST_UTILS_H_
 #define CONTENT_PUBLIC_TEST_BROWSER_TEST_UTILS_H_
 
 #include <queue>
 #include <string>
 #include <vector>
@@ skipping 191 matching lines @@
   RenderFrameHost* render_frame_host_;
 };
 
 RenderFrameHost* ConvertToRenderFrameHost(RenderViewHost* render_view_host);
 RenderFrameHost* ConvertToRenderFrameHost(RenderFrameHost* render_view_host);
 RenderFrameHost* ConvertToRenderFrameHost(WebContents* web_contents);
 
 // Executes the passed |script| in the specified frame with the user gesture.
 // The |script| should not invoke domAutomationController.send(); otherwise,
 // your test will hang or be flaky. If you want to extract a result, use one of
 // the below functions. Returns true on success.

[mmenke, 2017/07/06 16:10:34]

While you're here, mind documenting what "success" is?  From the comment in
ExecuteUnmodifiedScript, I assume it at least waits for the script to finish
running, but I'm still not sure what success is.  If the script throws an
exception, is that success?

[Łukasz Anforowicz, 2017/07/06 16:46:56]

Done.

 bool ExecuteScript(const ToRenderFrameHost& adapter,
                    const std::string& script) WARN_UNUSED_RESULT;
 
 // Same as content::ExecuteScript but doesn't send a user gesture to the
 // renderer.
 bool ExecuteScriptWithoutUserGesture(const ToRenderFrameHost& adapter,
                                      const std::string& script)
     WARN_UNUSED_RESULT;
 
-// The following methods execute the passed |script| in the specified frame with
-// the user gesture and set |result| to the value passed to
-// "window.domAutomationController.send" by the executed script. They return
-// true on success, false if the script execution failed or did not evaluate to
-// the expected type.
+// Kicks off execution of the |script| in the specified frame and returns
+// immediately (unlike ExecuteScript above).

[mmenke, 2017/07/06 16:10:34]

I guess ExecuteScript waits for completion?  That should be documented with
ExecuteScript.

[Łukasz Anforowicz, 2017/07/06 16:46:56]

Done.

+//
+// This function is useful when extra calls to domAutomationController.send
+// are undesirable.
+void ExecuteUnmodifiedScript(const ToRenderFrameHost& adapter,

[mmenke, 2017/07/06 16:10:34]

ExecuteUnmodifiedScript?  Does ExecuteScript modify the script?  If so, perhaps
that should be documented, as it's not clear what makes this script not
modified.

[Łukasz Anforowicz, 2017/07/06 16:46:56]

Done.

+                             const std::string& script);
+
+// The following methods execute the passed |script| in the specified frame and
+// sets |result| to the value passed to "window.domAutomationController.send" by
+// the executed script. They return true on success, false if the script
+// execution failed or did not evaluate to the expected type.
 bool ExecuteScriptAndExtractDouble(const ToRenderFrameHost& adapter,
                                    const std::string& script,
                                    double* result) WARN_UNUSED_RESULT;
 bool ExecuteScriptAndExtractInt(const ToRenderFrameHost& adapter,
                                 const std::string& script,
                                 int* result) WARN_UNUSED_RESULT;
 bool ExecuteScriptAndExtractBool(const ToRenderFrameHost& adapter,
                                  const std::string& script,
                                  bool* result) WARN_UNUSED_RESULT;
 bool ExecuteScriptAndExtractString(const ToRenderFrameHost& adapter,
@@ skipping 277 matching lines @@
                const NotificationSource& source,
                const NotificationDetails& details) override;
 
   // Overridden WebContentsObserver methods.
   void RenderProcessGone(base::TerminationStatus status) override;
 
  private:
   NotificationRegistrar registrar_;
   std::queue<std::string> message_queue_;
   scoped_refptr<MessageLoopRunner> message_loop_runner_;
+  bool renderer_crashed_ = false;
 
   DISALLOW_COPY_AND_ASSIGN(DOMMessageQueue);
 };
 
 // Used to wait for a new WebContents to be created. Instantiate this object
 // before the operation that will create the window.
 class WebContentsAddedObserver {
  public:
   WebContentsAddedObserver();
   ~WebContentsAddedObserver();
@@ skipping 330 matching lines @@
   virtual ~MockOverscrollController() {}
 
   // Waits until the mock receives a consumed GestureScrollUpdate.
   virtual void WaitForConsumedScroll() = 0;
 };
 #endif  // defined(USE_AURA)
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_TEST_BROWSER_TEST_UTILS_H_