events: Make it a separate component from ui.

events: Create a separate events component out of ui.

BUG=none
R=ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226105

[sadrul, 2013-09-26 20:39:50]

Looks like it's possible to split events without separating out gfx first.

[Ben Goodger (Google), 2013-09-26 20:44:38]

lgtm

https://codereview.chromium.org/24788002/diff/12001/cc/cc.gyp
File cc/cc.gyp (right):

https://codereview.chromium.org/24788002/diff/12001/cc/cc.gyp#newcode20
cc/cc.gyp:20: '<(DEPTH)/ui/events/events.gyp:events',
it would be interesting to understand the reason for this dependency?

[sadrul, 2013-09-26 20:49:31]

https://codereview.chromium.org/24788002/diff/12001/cc/cc.gyp
File cc/cc.gyp (right):

https://codereview.chromium.org/24788002/diff/12001/cc/cc.gyp#newcode20
cc/cc.gyp:20: '<(DEPTH)/ui/events/events.gyp:events',
On 2013/09/26 20:44:39, Ben Goodger (Google) wrote:
> it would be interesting to understand the reason for this dependency?

cc uses just the LatencyInfo. (perhaps it could move into ui/gfx/?)

[Ben Goodger (Google), 2013-09-26 21:13:00]

ah, LatencyInfo. I don't like the way it refers to higher level components
which smells like a layering violation, but haven't spent enough time
looking at it to see what the split should be.

-Ben


On Thu, Sep 26, 2013 at 1:49 PM, <sadrul@chromium.org> wrote:

>
>
https://codereview.chromium.**org/24788002/diff/12001/cc/cc.**gyp<https://cod...
> File cc/cc.gyp (right):
>
> https://codereview.chromium.**org/24788002/diff/12001/cc/cc.**
>
gyp#newcode20<https://codereview.chromium.org/24788002/diff/12001/cc/cc.gyp#newcode20>
> cc/cc.gyp:20: '<(DEPTH)/ui/events/events.**gyp:events',
> On 2013/09/26 20:44:39, Ben Goodger (Google) wrote:
>
>> it would be interesting to understand the reason for this dependency?
>>
>
> cc uses just the LatencyInfo. (perhaps it could move into ui/gfx/?)
>
>
https://codereview.chromium.**org/24788002/<https://codereview.chromium.org/2...
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[danakj, 2013-09-26 21:18:46]

On Thu, Sep 26, 2013 at 2:12 PM, Ben Goodger (Google) <ben@chromium.org>wrote:

> ah, LatencyInfo. I don't like the way it refers to higher level components
> which smells like a layering violation, but haven't spent enough time
> looking at it to see what the split should be.
>

Possibly a good place for LatencyInfo will be whereever
WebGraphicsContext3DInProcessImpl and friends end up that are in
webkit/common/gpu right now - they're also things used by both content/ and
cc/.


>
> -Ben
>
>
> On Thu, Sep 26, 2013 at 1:49 PM, <sadrul@chromium.org> wrote:
>
>>
>>
https://codereview.chromium.**org/24788002/diff/12001/cc/cc.**gyp<https://cod...
>> File cc/cc.gyp (right):
>>
>> https://codereview.chromium.**org/24788002/diff/12001/cc/cc.**
>>
gyp#newcode20<https://codereview.chromium.org/24788002/diff/12001/cc/cc.gyp#newcode20>
>> cc/cc.gyp:20: '<(DEPTH)/ui/events/events.**gyp:events',
>> On 2013/09/26 20:44:39, Ben Goodger (Google) wrote:
>>
>>> it would be interesting to understand the reason for this dependency?
>>>
>>
>> cc uses just the LatencyInfo. (perhaps it could move into ui/gfx/?)
>>
>>
https://codereview.chromium.**org/24788002/<https://codereview.chromium.org/2...
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[sadrul, 2013-09-30 19:29:24]

I have updated the patch now that gfx is a separate component. The trybots are
looking happier with the latest patchset. If things don't break, I plan on
landing this later today/tonight.

[sadrul, 2013-10-01 01:45:00]

Committed patchset #8 manually as r226105 (presubmit successful).