Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp

Issue 2478783002: Resolve FetchEvent.preloadResponse with undefined when Navigation Preload is disabled. (Closed)
Patch Set: ScriptPromiseProperty::resolveWithUndefined() Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp
diff --git a/third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp b/third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp
index 76dff738f3bb228eaf14be2968c90c770aa3338f..e5ed5d50a789b6fe23b99f6c95b5346ebaae8142 100644
--- a/third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp
+++ b/third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp
@@ -76,11 +76,8 @@ FetchEvent::FetchEvent(ScriptState* scriptState,
scriptState->getExecutionContext(),
this,
PreloadResponseProperty::PreloadResponse)) {
- if (!navigationPreloadSent) {
- // TODO(horo): This behavior is still under the spec discussion.
- // https://github.com/w3c/ServiceWorker/issues/920#issuecomment-255874864
- m_preloadResponseProperty->resolve(nullptr);
- }
+ if (!navigationPreloadSent)
+ m_preloadResponseProperty->resolveWithUndefined();
m_clientId = initializer.clientId();
m_isReload = initializer.isReload();

Powered by Google App Engine
This is Rietveld 408576698