Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2478773002: [MD History] Disable menu button when history deletion is disabled. (Closed)

Created:
4 years, 1 month ago by calamity
Modified:
4 years, 1 month ago
Reviewers:
tsergeant
CC:
chromium-reviews, asanka, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, dbeam+watch-downloads_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD History] Disable menu button when history deletion is disabled. This CL disables the 'Remove from history' button on the history item menu when history deletion isn't allowed. BUG=662272 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/e1232ea6226cd1bdfe1e7f9e89fd049dd4bbeecb Cr-Commit-Position: refs/heads/master@{#432121}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -15 lines) Patch
M chrome/browser/resources/md_history/app.crisper.js View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_history/app.vulcanized.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_history/lazy_load.crisper.js View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_history/lazy_load.vulcanized.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_history/list_container.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_history/list_container.js View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/test/data/webui/md_history/history_supervised_user_test.js View 2 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
calamity
4 years, 1 month ago (2016-11-08 06:55:58 UTC) #3
tsergeant
lgtm
4 years, 1 month ago (2016-11-08 23:28:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2478773002/20001
4 years, 1 month ago (2016-11-15 04:00:07 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-15 05:54:29 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 05:59:03 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e1232ea6226cd1bdfe1e7f9e89fd049dd4bbeecb
Cr-Commit-Position: refs/heads/master@{#432121}

Powered by Google App Engine
This is Rietveld 408576698