Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2478763003: Revert of use reversePathTo in place of addPathReverse (Closed)

Created:
4 years, 1 month ago by caryclark
Modified:
4 years, 1 month ago
Reviewers:
reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of use reversePathTo in place of addPathReverse (patchset #1 id:1 of https://codereview.chromium.org/2481463002/ ) Reason for revert: breqking some bots Original issue's description: > use reversePathTo in place of addPathReverse > > Path ops was using addPathReverse, instead of reversePathTo. > The former adds a moveTo always, and the latter requires > that the caller add the moveTo if needed. > > Simplify the reversePathTo implementation. > > R=reed@google.com > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2481463002 > > Committed: https://skia.googlesource.com/skia/+/d8db392be9dd1887df04b10b5670991d6b098c17 TBR=reed@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/2fd58a29d305accdefdcd7c7dbf1b902cd758a84

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -36 lines) Patch
M include/core/SkPath.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/pathops/SkPathOps.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/core/SkPath.cpp View 1 chunk +29 lines, -18 lines 0 comments Download
M src/pathops/SkOpBuilder.cpp View 3 chunks +7 lines, -13 lines 0 comments Download
M src/pathops/SkPathWriter.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
caryclark
Created Revert of use reversePathTo in place of addPathReverse
4 years, 1 month ago (2016-11-04 20:31:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2478763003/1
4 years, 1 month ago (2016-11-04 20:31:49 UTC) #3
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 20:31:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2fd58a29d305accdefdcd7c7dbf1b902cd758a84

Powered by Google App Engine
This is Rietveld 408576698