Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollbarThemeAura.cpp

Issue 2478743003: add Tickmarks to aura overlay scrollbar (Closed)
Patch Set: typo Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scroll/ScrollbarThemeAura.cpp
diff --git a/third_party/WebKit/Source/platform/scroll/ScrollbarThemeAura.cpp b/third_party/WebKit/Source/platform/scroll/ScrollbarThemeAura.cpp
index 313a21e6f2ff071a450f4e00f4daf53da268e679..ce7f749a4d760737b9a7f0b6cb4f14efbc2aa099 100644
--- a/third_party/WebKit/Source/platform/scroll/ScrollbarThemeAura.cpp
+++ b/third_party/WebKit/Source/platform/scroll/ScrollbarThemeAura.cpp
@@ -34,7 +34,6 @@
#include "platform/PlatformMouseEvent.h"
#include "platform/RuntimeEnabledFeatures.h"
#include "platform/graphics/GraphicsContext.h"
-#include "platform/graphics/GraphicsContextStateSaver.h"
#include "platform/graphics/paint/DrawingRecorder.h"
#include "platform/scroll/ScrollableArea.h"
#include "platform/scroll/Scrollbar.h"
@@ -225,46 +224,6 @@ int ScrollbarThemeAura::minimumThumbLength(
return size.width();
}
-void ScrollbarThemeAura::paintTickmarks(GraphicsContext& context,
- const Scrollbar& scrollbar,
- const IntRect& rect) {
- if (scrollbar.orientation() != VerticalScrollbar)
- return;
-
- if (rect.height() <= 0 || rect.width() <= 0)
- return;
-
- // Get the tickmarks for the frameview.
- Vector<IntRect> tickmarks;
- scrollbar.getTickmarks(tickmarks);
- if (!tickmarks.size())
- return;
-
- if (DrawingRecorder::useCachedDrawingIfPossible(
- context, scrollbar, DisplayItem::kScrollbarTickmarks))
- return;
-
- DrawingRecorder recorder(context, scrollbar, DisplayItem::kScrollbarTickmarks,
- rect);
- GraphicsContextStateSaver stateSaver(context);
- context.setShouldAntialias(false);
-
- for (Vector<IntRect>::const_iterator i = tickmarks.begin();
- i != tickmarks.end(); ++i) {
- // Calculate how far down (in %) the tick-mark should appear.
- const float percent = static_cast<float>(i->y()) / scrollbar.totalSize();
-
- // Calculate how far down (in pixels) the tick-mark should appear.
- const int yPos = rect.y() + (rect.height() * percent);
-
- FloatRect tickRect(rect.x(), yPos, rect.width(), 3);
- context.fillRect(tickRect, Color(0xCC, 0xAA, 0x00, 0xFF));
-
- FloatRect tickStroke(rect.x(), yPos + 1, rect.width(), 1);
- context.fillRect(tickStroke, Color(0xFF, 0xDD, 0x00, 0xFF));
- }
-}
-
void ScrollbarThemeAura::paintTrackBackground(GraphicsContext& context,
const Scrollbar& scrollbar,
const IntRect& rect) {

Powered by Google App Engine
This is Rietveld 408576698