Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 2478733002: Page Info (native Mac): remove images from accessibility order (Closed)

Created:
4 years, 1 month ago by lgarron
Modified:
4 years, 1 month ago
CC:
nektarios, chromium-reviews, dmazzoni, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Page Info (native Mac): remove images from accessibility order Images are accompanied by descriptive text, so it is unnecessary for them to be int he accessibility order. (Currently, they are also read as "image", which is not useful.) BUG=660239 Committed: https://crrev.com/b8160f6a36c45ec4fc0cdfb9d47ebffcb2bafa69 Cr-Commit-Position: refs/heads/master@{#431068}

Patch Set 1 #

Patch Set 2 : Try something that actually works. #

Patch Set 3 : Separate the hack into a method for conceptual isolation (and maintainability). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm View 1 2 1 chunk +13 lines, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
lgarron
rsesek@, could you review?
4 years, 1 month ago (2016-11-08 20:32:48 UTC) #3
Elly Fong-Jones
lgtm
4 years, 1 month ago (2016-11-09 15:57:17 UTC) #6
Robert Sesek
lgtm
4 years, 1 month ago (2016-11-09 15:58:30 UTC) #7
nektarios
lgtm
4 years, 1 month ago (2016-11-09 16:07:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2478733002/40001
4 years, 1 month ago (2016-11-09 22:00:26 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-09 23:05:53 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 23:15:52 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b8160f6a36c45ec4fc0cdfb9d47ebffcb2bafa69
Cr-Commit-Position: refs/heads/master@{#431068}

Powered by Google App Engine
This is Rietveld 408576698