Remove net::Filter code

Remove net::Filter code

This CL removes net::Filter code since the new net::SourceStream API is
integrated.

This CL additionally cleans up SDCH UMAs that no longer exist in the codebase.

BUG=474859
Committed: https://crrev.com/fc37c3c876af6913eecca1140240777b10377309
Cr-Commit-Position: refs/heads/master@{#431302}

[xunjieli, 2016-11-04 19:48:31]

The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 19:49:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 19:57:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 19:57:38]

Dry run: Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)

[xunjieli, 2016-11-04 20:00:26]

The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 20:02:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 20:10:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 20:10:42]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[xunjieli, 2016-11-07 14:35:09]

The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run

[xunjieli, 2016-11-07 14:35:18]

Patchset #2 (id:20001) has been deleted

[commit-bot: I haz the power, 2016-11-07 14:35:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 14:53:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 14:53:51]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xunjieli, 2016-11-07 17:27:50]

Patchset #2 (id:40001) has been deleted

[xunjieli, 2016-11-07 17:27:56]

The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 17:28:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 17:41:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 17:41:02]

Dry run: Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[xunjieli, 2016-11-08 21:51:02]

Patchset #2 (id:60001) has been deleted

[xunjieli, 2016-11-08 21:51:10]

Patchset #1 (id:1) has been deleted

[xunjieli, 2016-11-08 21:53:12]

The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 21:53:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xunjieli, 2016-11-08 21:55:33]

xunjieli@chromium.org changed reviewers:
+ mmenke@chromium.org, rdsmith@chromium.org

[xunjieli, 2016-11-08 21:55:34]

Sending this out early mainly because I don't really know how to deal with
removing/deprecating SDCH histograms.

Should I mark those obsolete or delete them? I also see that there are a couple
which are not used. Do you want me to deal with those maybe in a separate CL?

Thanks!

Please take your time in reviewing.

[mmenke, 2016-11-08 21:58:17]

On 2016/11/08 21:55:34, xunjieli wrote:
> Sending this out early mainly because I don't really know how to deal with
> removing/deprecating SDCH histograms.
> 
> Should I mark those obsolete or delete them? I also see that there are a
couple
> which are not used. Do you want me to deal with those maybe in a separate CL?
> 
> Thanks!
> 
> Please take your time in reviewing.

Make them obsolete, rather than delete them (That prevents the name from being
used in the future, and merging new data with data from a 15-year-old version of
Chrome in the same histogram).

I'm fine with marking histograms that are non-existent as obsolete in the same
CL, though a purist may well disagree.

[Randy Smith (Not in Mondays), 2016-11-08 22:15:16]

On 2016/11/08 21:58:17, mmenke wrote:
> On 2016/11/08 21:55:34, xunjieli wrote:
> > Sending this out early mainly because I don't really know how to deal with
> > removing/deprecating SDCH histograms.
> > 
> > Should I mark those obsolete or delete them? I also see that there are a
> couple
> > which are not used. Do you want me to deal with those maybe in a separate
CL?
> > 
> > Thanks!
> > 
> > Please take your time in reviewing.
> 
> Make them obsolete, rather than delete them (That prevents the name from being
> used in the future, and merging new data with data from a 15-year-old version
of
> Chrome in the same histogram).
> 
> I'm fine with marking histograms that are non-existent as obsolete in the same
> CL, though a purist may well disagree.

Not this particular purist; that would be fine by me.

(Haven't looked at the CL; let me know when it's ready for final review.)

[xunjieli, 2016-11-08 22:16:28]

The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 22:17:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xunjieli, 2016-11-08 22:17:31]

On 2016/11/08 22:15:16, Randy Smith - Not in Mondays wrote:
> On 2016/11/08 21:58:17, mmenke wrote:
> > On 2016/11/08 21:55:34, xunjieli wrote:
> > > Sending this out early mainly because I don't really know how to deal with
> > > removing/deprecating SDCH histograms.
> > > 
> > > Should I mark those obsolete or delete them? I also see that there are a
> > couple
> > > which are not used. Do you want me to deal with those maybe in a separate
> CL?
> > > 
> > > Thanks!
> > > 
> > > Please take your time in reviewing.
> > 
> > Make them obsolete, rather than delete them (That prevents the name from
being
> > used in the future, and merging new data with data from a 15-year-old
version
> of
> > Chrome in the same histogram).
> > 
> > I'm fine with marking histograms that are non-existent as obsolete in the
same
> > CL, though a purist may well disagree.
> 
> Not this particular purist; that would be fine by me.
> 
> (Haven't looked at the CL; let me know when it's ready for final review.)


Done. Thanks for the suggestion! If Randy feels strongly, I will leave the other
SDCH histograms that are not removed in this CL untouched.
PTAL.

[commit-bot: I haz the power, 2016-11-09 00:01:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 00:01:42]

Dry run: This issue passed the CQ dry run.

[mmenke, 2016-11-09 17:15:44]

https://codereview.chromium.org/2478703004/diff/100001/tools/metrics/histogra...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/2478703004/diff/100001/tools/metrics/histogra...
tools/metrics/histograms/histograms.xml:55504: <histogram
name="Sdch3.Network_Decode_Bytes_Processed_b" units="bytes">
Processed_a is gone, but it looks like this one is still in
url_request_http_job.cc.

[mmenke, 2016-11-09 17:16:42]

https://codereview.chromium.org/2478703004/diff/100001/tools/metrics/histogra...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/2478703004/diff/100001/tools/metrics/histogra...
tools/metrics/histograms/histograms.xml:55504: <histogram
name="Sdch3.Network_Decode_Bytes_Processed_b" units="bytes">
On 2016/11/09 17:15:44, mmenke wrote:
> Processed_a is gone, but it looks like this one is still in
> url_request_http_job.cc.

If Randy doesn't object, I'd suggest just removing it in this CL.

[xunjieli, 2016-11-09 21:23:23]

Good catch! Thanks for the review. PTAL.

https://codereview.chromium.org/2478703004/diff/100001/tools/metrics/histogra...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/2478703004/diff/100001/tools/metrics/histogra...
tools/metrics/histograms/histograms.xml:55504: <histogram
name="Sdch3.Network_Decode_Bytes_Processed_b" units="bytes">
On 2016/11/09 17:15:44, mmenke wrote:
> Processed_a is gone, but it looks like this one is still in
> url_request_http_job.cc.

Done. Good catch! I think I will not deprecate this in this CL since it is still
being used. But I agree with you that we might want to remove it ultimately if
the histogram is no longer meaningful.

[mmenke, 2016-11-09 21:28:31]

LGTM

[Randy Smith (Not in Mondays), 2016-11-10 16:08:00]

I don't imagine I'd have any differences of perspective or insight with Matt on
this CL; I'll defer to his stamp.

[xunjieli, 2016-11-10 16:09:09]

On 2016/11/10 16:08:00, Randy Smith - Not in Mondays wrote:
> I don't imagine I'd have any differences of perspective or insight with Matt
on
> this CL; I'll defer to his stamp.

Thank you both. I will CQ this today. I think there's no way going back. I will
try fixing issues one by one as they come in. I hope there are not many left!

[xunjieli, 2016-11-10 16:09:17]

The CQ bit was checked by xunjieli@chromium.org

[xunjieli, 2016-11-10 16:09:19]

The CQ bit was unchecked by xunjieli@chromium.org

[xunjieli, 2016-11-10 16:11:18]

xunjieli@chromium.org changed reviewers:
+ isherman@chromium.org

[xunjieli, 2016-11-10 16:11:19]

isherman@: Please review changes in 
tools/metrics/histograms/histograms.xml


Thanks!

[xunjieli, 2016-11-10 16:11:33]

The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 16:11:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 18:32:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 18:32:41]

Dry run: This issue passed the CQ dry run.

[Ilya Sherman, 2016-11-10 18:37:04]

histograms.xml lgtm, thanks

[xunjieli, 2016-11-10 18:38:38]

On 2016/11/10 18:37:04, Ilya Sherman wrote:
> histograms.xml lgtm, thanks

Thanks a lot! Really appreciate the quick reply.

[xunjieli, 2016-11-10 18:38:48]

The CQ bit was checked by xunjieli@chromium.org

[commit-bot: I haz the power, 2016-11-10 18:39:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 18:46:09]

Committed patchset #3 (id:120001)

[commit-bot: I haz the power, 2016-11-10 19:09:09]

Description was changed from

==========
Remove net::Filter code

This CL removes net::Filter code since the new net::SourceStream API is
integrated.

This CL additionally cleans up SDCH UMAs that no longer exist in the codebase.

BUG=474859
==========

to

==========
Remove net::Filter code

This CL removes net::Filter code since the new net::SourceStream API is
integrated.

This CL additionally cleans up SDCH UMAs that no longer exist in the codebase.

BUG=474859

Committed: https://crrev.com/fc37c3c876af6913eecca1140240777b10377309
Cr-Commit-Position: refs/heads/master@{#431302}
==========

[commit-bot: I haz the power, 2016-11-10 19:09:10]

Patchset 3 (id:??) landed as
https://crrev.com/fc37c3c876af6913eecca1140240777b10377309
Cr-Commit-Position: refs/heads/master@{#431302}