Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Issue 2478703003: Run async immediately in dart2js and VM. (Closed)

Created:
4 years, 1 month ago by floitsch
Modified:
3 years, 3 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Run async immediately in dart2js and VM.

Patch Set 1 #

Patch Set 2 : Also run sync in VM. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -22 lines) Patch
M pkg/compiler/lib/src/common_elements.dart View 1 1 chunk +1 line, -1 line 1 comment Download
M runtime/lib/async_patch.dart View 1 1 chunk +35 lines, -0 lines 0 comments Download
M runtime/vm/parser.cc View 1 3 chunks +16 lines, -18 lines 0 comments Download
M runtime/vm/symbols.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/async_patch.dart View 1 2 chunks +38 lines, -3 lines 1 comment Download

Messages

Total messages: 7 (3 generated)
Vyacheslav Egorov (Google)
This CL also needs to update Kernel async transform.
3 years, 4 months ago (2017-08-21 16:15:37 UTC) #3
asandholm
On 2017/08/21 16:15:37, Vyacheslav Egorov (Google) wrote: > This CL also needs to update Kernel ...
3 years, 4 months ago (2017-08-24 16:56:54 UTC) #4
sra1
https://codereview.chromium.org/2478703003/diff/20001/pkg/compiler/lib/src/common_elements.dart File pkg/compiler/lib/src/common_elements.dart (right): https://codereview.chromium.org/2478703003/diff/20001/pkg/compiler/lib/src/common_elements.dart#newcode550 pkg/compiler/lib/src/common_elements.dart:550: _env.lookupConstructor(_findAsyncHelperClass("_AsyncAwaitCompleter"), ""); This is confusing. Why is the 'sync' ...
3 years, 4 months ago (2017-08-24 17:21:18 UTC) #6
floitsch
3 years, 3 months ago (2017-09-12 14:00:47 UTC) #7

Powered by Google App Engine
This is Rietveld 408576698