Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2478703002: [DevTools] Remove handlers = browser from protocol definition. (Closed)

Created:
4 years, 1 month ago by dgozman
Modified:
4 years, 1 month ago
Reviewers:
kozy, caseq, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, jam, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, darin-cc_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Remove handlers = browser from protocol definition. Content generator is now aware of the methods it should generate. Same will be done for blink generator in next patch. BUG=635953 Committed: https://crrev.com/d99d907ee8cc3450c02c607125bb24f5d313fb97 Cr-Commit-Position: refs/heads/master@{#429807}

Patch Set 1 #

Total comments: 4

Patch Set 2 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+326 lines, -173 lines) Patch
M chrome/browser/devtools/devtools_protocol_constants_generator.py View 1 4 chunks +10 lines, -12 lines 0 comments Download
M content/browser/devtools/protocol/devtools_protocol_handler_generator.py View 1 5 chunks +28 lines, -6 lines 0 comments Download
M content/browser/devtools/protocol/emulation_handler.h View 2 chunks +10 lines, -0 lines 0 comments Download
M content/browser/devtools/protocol/emulation_handler.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M content/browser/devtools/protocol/input_handler.h View 1 chunk +6 lines, -0 lines 0 comments Download
M content/browser/devtools/protocol/input_handler.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M content/browser/devtools/protocol/memory_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/devtools/protocol/memory_handler.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M content/browser/devtools/protocol/page_handler.h View 1 chunk +27 lines, -0 lines 0 comments Download
M content/browser/devtools/protocol/page_handler.cc View 1 chunk +60 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/report-protocol-errors.html View 1 chunk +13 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/report-protocol-errors-expected.txt View 13 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/browser_protocol.json View 84 chunks +109 lines, -129 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
dgozman
Take a look please.
4 years, 1 month ago (2016-11-04 00:19:18 UTC) #2
caseq
lgtm https://codereview.chromium.org/2478703002/diff/1/chrome/browser/devtools/devtools_protocol_constants_generator.py File chrome/browser/devtools/devtools_protocol_constants_generator.py (right): https://codereview.chromium.org/2478703002/diff/1/chrome/browser/devtools/devtools_protocol_constants_generator.py#newcode86 chrome/browser/devtools/devtools_protocol_constants_generator.py:86: return s.replace("-", "_") Let's CamelCase those instead? https://codereview.chromium.org/2478703002/diff/1/content/browser/devtools/protocol/devtools_protocol_handler_generator.py ...
4 years, 1 month ago (2016-11-04 01:20:40 UTC) #4
dgozman
https://codereview.chromium.org/2478703002/diff/1/chrome/browser/devtools/devtools_protocol_constants_generator.py File chrome/browser/devtools/devtools_protocol_constants_generator.py (right): https://codereview.chromium.org/2478703002/diff/1/chrome/browser/devtools/devtools_protocol_constants_generator.py#newcode86 chrome/browser/devtools/devtools_protocol_constants_generator.py:86: return s.replace("-", "_") On 2016/11/04 01:20:40, caseq wrote: > ...
4 years, 1 month ago (2016-11-04 01:52:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2478703002/20001
4 years, 1 month ago (2016-11-04 01:54:11 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-04 06:03:25 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 06:07:17 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d99d907ee8cc3450c02c607125bb24f5d313fb97
Cr-Commit-Position: refs/heads/master@{#429807}

Powered by Google App Engine
This is Rietveld 408576698