Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2478653003: Clean up dead InterfaceRegistry instances in ServiceContext (Closed)

Created:
4 years, 1 month ago by Ken Rockot(use gerrit already)
Modified:
4 years, 1 month ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up dead InterfaceRegistry instances in ServiceContext BUG=654986 R=ben@chromium.org Committed: https://crrev.com/d783757f32d5f8c475e44b9447197fc320961195 Cr-Commit-Position: refs/heads/master@{#429799}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -14 lines) Patch
M content/common/service_manager/service_manager_connection_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/public/cpp/interface_registry.h View 4 chunks +6 lines, -1 line 0 comments Download
M services/service_manager/public/cpp/lib/interface_registry.cc View 3 chunks +9 lines, -2 lines 0 comments Download
M services/service_manager/public/cpp/lib/service_context.cc View 1 2 3 4 4 chunks +27 lines, -4 lines 0 comments Download
M services/service_manager/public/cpp/service_context.h View 1 2 3 4 4 chunks +12 lines, -5 lines 0 comments Download
M services/service_manager/tests/connect/connect_test_class_app.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 26 (19 generated)
Ken Rockot(use gerrit already)
4 years, 1 month ago (2016-11-03 22:37:44 UTC) #4
Ben Goodger (Google)
lgtm
4 years, 1 month ago (2016-11-04 00:11:01 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2478653003/90001
4 years, 1 month ago (2016-11-04 01:29:57 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/325298)
4 years, 1 month ago (2016-11-04 03:58:07 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2478653003/90001
4 years, 1 month ago (2016-11-04 04:02:46 UTC) #23
commit-bot: I haz the power
Committed patchset #6 (id:90001)
4 years, 1 month ago (2016-11-04 05:39:52 UTC) #24
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 05:43:23 UTC) #26
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/d783757f32d5f8c475e44b9447197fc320961195
Cr-Commit-Position: refs/heads/master@{#429799}

Powered by Google App Engine
This is Rietveld 408576698