Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Side by Side Diff: third_party/WebKit/Source/wtf/text/TextCodecICU.h

Issue 2478653002: Don't initialize ICU replacement character for UTF-32 encodings (Closed)
Patch Set: Don't use zero-length array initializer, to keep MSVC happy Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2006, 2007, 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2004, 2006, 2007, 2011 Apple Inc. All rights reserved.
3 * Copyright (C) 2006 Alexey Proskuryakov <ap@nypop.com> 3 * Copyright (C) 2006 Alexey Proskuryakov <ap@nypop.com>
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 bool flush, 80 bool flush,
81 UErrorCode&); 81 UErrorCode&);
82 82
83 TextEncoding m_encoding; 83 TextEncoding m_encoding;
84 mutable UConverter* m_converterICU; 84 mutable UConverter* m_converterICU;
85 #if defined(USING_SYSTEM_ICU) 85 #if defined(USING_SYSTEM_ICU)
86 mutable bool m_needsGBKFallbacks; 86 mutable bool m_needsGBKFallbacks;
87 #endif 87 #endif
88 88
89 FRIEND_TEST_ALL_PREFIXES(TextCodecICUTest, IgnorableCodePoint); 89 FRIEND_TEST_ALL_PREFIXES(TextCodecICUTest, IgnorableCodePoint);
90 FRIEND_TEST_ALL_PREFIXES(TextCodecICUTest, UTF32AndQuestionMarks);
91 FRIEND_TEST_ALL_PREFIXES(TextCodecICUTest, UTF32Aliases);
90 }; 92 };
91 93
92 struct ICUConverterWrapper { 94 struct ICUConverterWrapper {
93 WTF_MAKE_NONCOPYABLE(ICUConverterWrapper); 95 WTF_MAKE_NONCOPYABLE(ICUConverterWrapper);
94 USING_FAST_MALLOC(ICUConverterWrapper); 96 USING_FAST_MALLOC(ICUConverterWrapper);
95 97
96 public: 98 public:
97 ICUConverterWrapper() : converter(0) {} 99 ICUConverterWrapper() : converter(0) {}
98 ~ICUConverterWrapper(); 100 ~ICUConverterWrapper();
99 101
100 UConverter* converter; 102 UConverter* converter;
101 }; 103 };
102 104
103 } // namespace WTF 105 } // namespace WTF
104 106
105 #endif // TextCodecICU_h 107 #endif // TextCodecICU_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/wtf/BUILD.gn ('k') | third_party/WebKit/Source/wtf/text/TextCodecICU.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698