Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2478623003: Disallow CSS custom properties as descriptors (Closed)

Created:
4 years, 1 month ago by Timothy Loh
Modified:
4 years, 1 month ago
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disallow CSS custom properties as descriptors CSS custom properties are properties so should be not allowed where we only otherwise allow descriptors. This patch makes the parser reject custom properties in at rules (excluding in keyframe blocks, which take properties instead of descriptors). BUG=641873 Committed: https://crrev.com/bfc0527d0b204f20d238d8e998f9485b637dd4a3 Cr-Commit-Position: refs/heads/master@{#430484}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -12 lines) Patch
A third_party/WebKit/LayoutTests/fast/css/variables/variables-in-at-rules.html View 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css/variables/variables-in-at-rules-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp View 1 chunk +8 lines, -12 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Timothy Loh
4 years, 1 month ago (2016-11-07 02:10:16 UTC) #7
rune
lgtm
4 years, 1 month ago (2016-11-07 09:48:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2478623003/1
4 years, 1 month ago (2016-11-08 00:26:51 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 02:34:49 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 03:27:22 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bfc0527d0b204f20d238d8e998f9485b637dd4a3
Cr-Commit-Position: refs/heads/master@{#430484}

Powered by Google App Engine
This is Rietveld 408576698