Remove EventSender in HTMLDetailsElement

Remove EventSender in HTMLDetailsElement

BUG=624697
Committed: https://crrev.com/77c635eea1e4f6a9b23f111e0b146463cd485498
Cr-Commit-Position: refs/heads/master@{#430877}

[hiroshige, 2016-11-04 11:48:11]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 11:48:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2016-11-04 11:52:56]

Description was changed from

==========
Remove EventSender in HTMLDetailsElement

BUG=
==========

to

==========
Remove EventSender in HTMLDetailsElement

BUG=624697
==========

[commit-bot: I haz the power, 2016-11-04 12:50:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 12:50:09]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2016-11-07 09:00:41]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 09:00:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2016-11-07 09:24:54]

hiroshige@chromium.org changed reviewers:
+ haraken@chromium.org, tzik@chromium.org

[hiroshige, 2016-11-07 09:24:55]

PTAL.

https://codereview.chromium.org/2478603003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLDetailsElement.cpp (right):

https://codereview.chromium.org/2478603003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLDetailsElement.cpp:131: m_pendingEvent =
Here previous event is canceled (because |m_pendingEvent| is overwritten).

[haraken, 2016-11-07 09:51:01]

LGTM but one question to tzik@.

https://codereview.chromium.org/2478603003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLDetailsElement.cpp (right):

https://codereview.chromium.org/2478603003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLDetailsElement.cpp:131: m_pendingEvent =

Hmm, we need to keep holding m_pendingEvent in order not to cancel the task...
which seems error-prone to me; i.e., if developers forget to hold the task
handle, the task will be unintentionally cancelled.

Would you help me understand why we wanted to adopt the cancel-on-destruction
semantics for TaskHandles?

[commit-bot: I haz the power, 2016-11-07 10:27:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 10:27:31]

Dry run: This issue passed the CQ dry run.

[tzik, 2016-11-08 08:30:08]

On 2016/11/07 09:51:01, haraken wrote:
> LGTM but one question to tzik@.
> 
>
https://codereview.chromium.org/2478603003/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/html/HTMLDetailsElement.cpp (right):
> 
>
https://codereview.chromium.org/2478603003/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/html/HTMLDetailsElement.cpp:131: m_pendingEvent
=
> 
> Hmm, we need to keep holding m_pendingEvent in order not to cancel the task...
> which seems error-prone to me; i.e., if developers forget to hold the task
> handle, the task will be unintentionally cancelled.
> 
> Would you help me understand why we wanted to adopt the cancel-on-destruction
> semantics for TaskHandles?

LGTM for this CL. Let's discuss this on the other CL.

[hiroshige, 2016-11-09 04:05:44]

The CQ bit was checked by hiroshige@chromium.org

[commit-bot: I haz the power, 2016-11-09 04:06:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 06:04:54]

Description was changed from

==========
Remove EventSender in HTMLDetailsElement

BUG=624697
==========

to

==========
Remove EventSender in HTMLDetailsElement

BUG=624697
==========

[commit-bot: I haz the power, 2016-11-09 06:04:55]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-09 06:08:30]

Description was changed from

==========
Remove EventSender in HTMLDetailsElement

BUG=624697
==========

to

==========
Remove EventSender in HTMLDetailsElement

BUG=624697

Committed: https://crrev.com/77c635eea1e4f6a9b23f111e0b146463cd485498
Cr-Commit-Position: refs/heads/master@{#430877}
==========

[commit-bot: I haz the power, 2016-11-09 06:08:31]

Patchset 2 (id:??) landed as
https://crrev.com/77c635eea1e4f6a9b23f111e0b146463cd485498
Cr-Commit-Position: refs/heads/master@{#430877}