Avoid params being initialized out of order in Fuzzer

fuzz/FuzzParsePath.cpp

 /*
  * Copyright 2016 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "Fuzz.h"
 #include "SkString.h"
 #include "SkParsePath.h"
@@ skipping 21 matching lines @@
 static bool gEasy = false;  // set to true while debugging to suppress unusual whitespace
 
 // mostly do nothing, then bias towards spaces
 static const char gWhiteSpace[] = { 0, 0, 0, 0, 0, 0, 0, 0, ' ', ' ', ' ', ' ', 0x09, 0x0D, 0x0A };
 
 static void add_white(Fuzz* fuzz, SkString* atom) {
     if (gEasy) {
         atom->append(" ");
         return;
     }
-    int reps = fuzz->nextRange(0, 2);
+    int reps; fuzz->nextRange(&reps, 0, 2);
     for (int rep = 0; rep < reps; ++rep) {
-        int index = fuzz->nextRange(0, (int) SK_ARRAY_COUNT(gWhiteSpace) - 1);
+        int index; fuzz->nextRange(&index, 0, (int) SK_ARRAY_COUNT(gWhiteSpace) - 1);
         if (gWhiteSpace[index]) {
             atom->append(&gWhiteSpace[index], 1);
         }
     }
 }
 
 static void add_some_white(Fuzz* fuzz, SkString* atom) {
     for(int i = 0; i < 10; i++) {
         add_white(fuzz, atom);
     }
 }
 
 static void add_comma(Fuzz* fuzz, SkString* atom) {
     if (gEasy) {
         atom->append(",");
         return;
     }
     add_white(fuzz, atom);
-    if (fuzz->next<bool>()) {
+    bool b; fuzz->next(&b);
+    if (b) {
         atom->append(",");
     }
     add_some_white(fuzz, atom);
 }
 
 SkString MakeRandomParsePathPiece(Fuzz* fuzz) {
     SkString atom;
-    int index = fuzz->nextRange(0, (int) SK_ARRAY_COUNT(gLegal) - 1);
+    int index; fuzz->nextRange(&index, 0, (int) SK_ARRAY_COUNT(gLegal) - 1);
     const Legal& legal = gLegal[index];
     gEasy ? atom.append("\n") : add_white(fuzz, &atom);
-    char symbol = legal.fSymbol | (fuzz->next<bool>() ? 0x20 : 0);
+    bool b; fuzz->next(&b);
+    char symbol = legal.fSymbol | (b ? 0x20 : 0);
     atom.append(&symbol, 1);
-    int reps = fuzz->nextRange(1, 3);
+    int reps; fuzz->nextRange(&reps, 1, 3);
     for (int rep = 0; rep < reps; ++rep) {
         for (int index = 0; index < legal.fScalars; ++index) {
-            SkScalar coord = fuzz->nextRange(0.0f, 100.0f);
+            SkScalar coord; fuzz->nextRange(&coord, 0.0f, 100.0f);
             add_white(fuzz, &atom);
             atom.appendScalar(coord);
             if (rep < reps - 1 && index < legal.fScalars - 1) {
                 add_comma(fuzz, &atom);
             } else {
                 add_some_white(fuzz, &atom);
             }
             if ('A' == legal.fSymbol && 1 == index) {
-                atom.appendScalar(fuzz->nextRange(-720.0f, 720.0f));
+                SkScalar s; fuzz->nextRange(&s, -720.0f, 720.0f);
+                atom.appendScalar(s);
                 add_comma(fuzz, &atom);
-                atom.appendU32(fuzz->nextRange(0, 1));
+                int i; fuzz->nextRange(&i, 0, 1);
+                atom.appendU32(i);
                 add_comma(fuzz, &atom);
-                atom.appendU32(fuzz->nextRange(0, 1));
+                fuzz->nextRange(&i, 0, 1);
+                atom.appendU32(i);
                 add_comma(fuzz, &atom);
             }
         }
     }
     return atom;
 }
 
 DEF_FUZZ(ParsePath, fuzz) {
     SkPath path;
     SkString spec;
-    uint32_t count = fuzz->nextRange(0, 40);
-    for (uint32_t i = 0; i < count; ++i) {
+    int count; fuzz->nextRange(&count, 0, 40);
+    for (int i = 0; i < count; ++i) {
         spec.append(MakeRandomParsePathPiece(fuzz));
     }
     SkDebugf("SkParsePath::FromSVGString(%s, &path);\n",spec.c_str());
     if (!SkParsePath::FromSVGString(spec.c_str(), &path)){
         SkDebugf("Could not decode path\n");
     }
 }