chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java - Issue 2478583004: implementation for new duplicate download UI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java

Issue 2478583004: implementation for new duplicate download UI (Closed)

Patch Set: do null check on webcontents Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/infobar/DuplicateDownloadInfoBar.java ('k') | chrome/android/java/strings/android_chrome_strings.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java

index 541fc9b9b1a0f7953674054614f426b2ac58ce6f..5a52c519349420db2d0afc226c66ee5b6cb3c29b 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java

@@ -7,11 +7,9 @@ package org.chromium.chrome.browser.offlinepages.downloads;

import android.content.ComponentName;

import android.support.annotation.Nullable;

-import org.chromium.base.ContextUtils;

import org.chromium.base.ObserverList;

import org.chromium.base.annotations.CalledByNative;

import org.chromium.base.annotations.JNINamespace;

-import org.chromium.chrome.R;

import org.chromium.chrome.browser.download.DownloadItem;

import org.chromium.chrome.browser.download.DownloadServiceDelegate;

import org.chromium.chrome.browser.download.ui.BackendProvider.OfflinePageDelegate;

@@ -198,8 +196,7 @@ public class OfflinePageDownloadBridge implements DownloadServiceDelegate, Offli

* @param tab a tab contents of which will be saved locally.

public void startDownload(Tab tab) {

- nativeStartDownload(mNativeOfflinePageDownloadBridge, tab,

- ContextUtils.getApplicationContext().getString(R.string.menu_downloads));

+ nativeStartDownload(mNativeOfflinePageDownloadBridge, tab);

}

/**

@@ -286,6 +283,5 @@ public class OfflinePageDownloadBridge implements DownloadServiceDelegate, Offli

native void nativeResumeDownload(long nativeOfflinePageDownloadBridge, String guid);

native void nativeDeleteItemByGuid(long nativeOfflinePageDownloadBridge, String guid);

native long nativeGetOfflineIdByGuid(long nativeOfflinePageDownloadBridge, String guid);

- native void nativeStartDownload(

- long nativeOfflinePageDownloadBridge, Tab tab, String downloadsLabel);

+ native void nativeStartDownload(long nativeOfflinePageDownloadBridge, Tab tab);

}