implementation for new duplicate download UI

chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.download;
 
 import android.Manifest.permission;
 import android.app.Activity;
 import android.app.DownloadManager;
 import android.content.Context;
 import android.content.DialogInterface;
 import android.content.pm.PackageManager;
 import android.net.Uri;
 import android.os.AsyncTask;
 import android.os.Environment;
 import android.support.v7.app.AlertDialog;
 import android.text.TextUtils;
-import android.util.Pair;
 import android.view.View;
 import android.webkit.MimeTypeMap;
 import android.webkit.URLUtil;
 import android.widget.TextView;
 
 import org.chromium.base.Log;
 import org.chromium.base.ThreadUtils;
 import org.chromium.base.annotations.CalledByNative;
 import org.chromium.chrome.R;
 import org.chromium.chrome.browser.ChromeActivity;
@@ skipping 49 matching lines @@
     protected void onDownloadStartNoStream(final DownloadInfo downloadInfo) {
         final String fileName = downloadInfo.getFileName();
         assert !TextUtils.isEmpty(fileName);
         final String newMimeType =
                 remapGenericMimeType(downloadInfo.getMimeType(), downloadInfo.getUrl(), fileName);
         new AsyncTask<Void, Void, Object[]>() {
             @Override
             protected Object[] doInBackground(Void... params) {
                 // Check to see if we have an SDCard.
                 String status = Environment.getExternalStorageState();
-                Pair<String, String> result = getDownloadDirectoryNameAndFullPath();
-                String dirName = result.first;
-                String fullDirPath = result.second;
-                boolean fileExists = doesFileAlreadyExists(fullDirPath, fileName);
+                File fullDirPath = getDownloadDirectoryFullPath();
+                boolean fileExists = checkFileExists(fullDirPath, fileName);
 
-                return new Object[] {status, dirName, fullDirPath, fileExists};
+                return new Object[] {status, fullDirPath, fileExists};
             }
 
             @Override
             protected void onPostExecute(Object[] result) {
                 String externalStorageState = (String) result[0];
-                String dirName = (String) result[1];
-                String fullDirPath = (String) result[2];
-                Boolean fileExists = (Boolean) result[3];
+                File fullDirPath = (File) result[1];
+                Boolean fileExists = (Boolean) result[2];
                 if (!checkExternalStorageAndNotify(
                         fileName, fullDirPath, externalStorageState)) {
                     return;
                 }
                 String url = sanitizeDownloadUrl(downloadInfo);
                 if (url == null) return;
                 DownloadInfo newInfo = DownloadInfo.Builder.fromDownloadInfo(downloadInfo)
                                                .setUrl(url)
                                                .setMimeType(newMimeType)
                                                .setDescription(url)
                                                .setFileName(fileName)
                                                .setIsGETRequest(true)
                                                .build();
 
                 // TODO(acleung): This is a temp fix to disable auto downloading if flash files.
                 // We want to avoid downloading flash files when it is linked as an iframe.
                 // The proper fix would be to let chrome knows which frame originated the request.
                 if ("application/x-shockwave-flash".equals(newInfo.getMimeType())) return;
 
                 // Not a dangerous file, proceed.
                 if (fileExists) {
-                    launchDownloadInfoBar(newInfo, dirName, fullDirPath);
+                    launchDownloadInfoBar(newInfo, fullDirPath);
                 } else {
                     enqueueDownloadManagerRequest(newInfo);
                 }
             }
         }.execute();
     }
 
     /**
      * Sanitize the URL for the download item.
      *
@@ skipping 55 matching lines @@
             builder.create().show();
         } else if (!mTab.getWindowAndroid().isPermissionRevokedByPolicy(storagePermission)) {
             nativeLaunchPermissionUpdateInfoBar(mTab, storagePermission, callbackId);
         } else {
             // TODO(tedchoc): Show toast.
             DownloadController.getInstance().onRequestFileAccessResult(callbackId, false);
         }
     }
 
     /**
-     * Return a pair of directory name and its full path. Note that we create the directory if
-     * it does not already exist.
+     * Return the full path of the download directory.
      *
-     * @return A pair of directory name and its full path. A pair of <null, null> will be returned
-     * in case of an error.
+     * @return File object containing the path to the download directory.
      */
-    private static Pair<String, String> getDownloadDirectoryNameAndFullPath() {
+    private static File getDownloadDirectoryFullPath() {
         assert !ThreadUtils.runningOnUiThread();
         File dir = Environment.getExternalStoragePublicDirectory(Environment.DIRECTORY_DOWNLOADS);
-        if (!dir.mkdir() && !dir.isDirectory()) return new Pair<>(null, null);
-        String dirName = dir.getName();
-        String fullDirPath = dir.getPath();
-        return new Pair<>(dirName, fullDirPath);
+        if (!dir.mkdir() && !dir.isDirectory()) return null;
+        return dir;
     }
 
-    private static boolean doesFileAlreadyExists(String dirPath, final String fileName) {
+    private static boolean checkFileExists(File dirPath, final String fileName) {
         assert !ThreadUtils.runningOnUiThread();
         final File file = new File(dirPath, fileName);
         return file != null && file.exists();
     }
 
     private static void deleteFileForOverwrite(DownloadInfo info) {
         assert !ThreadUtils.runningOnUiThread();
         File dir = Environment.getExternalStoragePublicDirectory(Environment.DIRECTORY_DOWNLOADS);
         if (!dir.isDirectory()) return;
         final File file = new File(dir, info.getFileName());
@@ skipping 27 matching lines @@
                 public void onPostExecute(Void args) {
                     enqueueDownloadManagerRequest(downloadInfo);
                 }
             }.execute();
         } else {
             enqueueDownloadManagerRequest(downloadInfo);
         }
         return closeBlankTab();
     }
 
-    private void launchDownloadInfoBar(DownloadInfo info, String dirName, String fullDirPath) {
+    private void launchDownloadInfoBar(DownloadInfo info, File fullDirPath) {
         if (mTab == null) return;
-        nativeLaunchDownloadOverwriteInfoBar(
-                ChromeDownloadDelegate.this, mTab, info, info.getFileName(), dirName, fullDirPath);
+        nativeLaunchDuplicateDownloadInfoBar(ChromeDownloadDelegate.this, mTab, info,
+                new File(fullDirPath, info.getFileName()).toString(), mTab.isIncognito());
     }
 
     /**
      * Enqueue a request to download a file using Android DownloadManager.
      *
      * @param info Download information about the download.
      */
     private void enqueueDownloadManagerRequest(final DownloadInfo info) {
         DownloadManagerService.getDownloadManagerService(
                 mContext.getApplicationContext()).enqueueDownloadManagerRequest(
                         new DownloadItem(true, info), true);
         closeBlankTab();
     }
 
     /**
      * Check the external storage and notify user on error.
      *
      * @param fullDirPath The dir path to download a file. Normally this is external storage.
      * @param externalStorageStatus The status of the external storage.
      * @return Whether external storage is ok for downloading.
      */
     private boolean checkExternalStorageAndNotify(
-            String filename, String fullDirPath, String externalStorageStatus) {
+            String filename, File fullDirPath, String externalStorageStatus) {
         if (fullDirPath == null) {
             Log.e(TAG, "Download failed: no SD card");
             alertDownloadFailure(
                     filename, DownloadManager.ERROR_DEVICE_NOT_FOUND);
             return false;
         }
         if (!externalStorageStatus.equals(Environment.MEDIA_MOUNTED)) {
             int reason = DownloadManager.ERROR_DEVICE_NOT_FOUND;
             // Check to see if the SDCard is busy, same as the music app
             if (externalStorageStatus.equals(Environment.MEDIA_SHARED)) {
@@ skipping 178 matching lines @@
         return true;
     }
 
     protected Context getContext() {
         return mContext;
     }
 
     private native void nativeInit(WebContents webContents);
     private static native String nativeGetDownloadWarningText(String filename);
     private static native boolean nativeIsDownloadDangerous(String filename);
-    private static native void nativeLaunchDownloadOverwriteInfoBar(ChromeDownloadDelegate delegate,
-            Tab tab, DownloadInfo downloadInfo, String fileName, String dirName,
-            String dirFullPath);
+    private static native void nativeLaunchDuplicateDownloadInfoBar(ChromeDownloadDelegate delegate,
+            Tab tab, DownloadInfo downloadInfo, String filePath, boolean isIncognito);
     private static native void nativeLaunchPermissionUpdateInfoBar(
             Tab tab, String permission, long callbackId);
 }