implementation for new duplicate download UI

components/infobars/core/infobar_delegate.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_INFOBARS_CORE_INFOBAR_DELEGATE_H_
 #define COMPONENTS_INFOBARS_CORE_INFOBAR_DELEGATE_H_
 
 #include "base/macros.h"
 #include "base/strings/string16.h"
 #include "build/build_config.h"
@@ skipping 56 matching lines @@
   // Unique identifier for every InfoBarDelegate subclass.
   // KEEP IN SYNC WITH THE InfoBarIdentifier ENUM IN histograms.xml.
   // NEW VALUES MUST BE APPENDED AND AVOID CHANGING ANY PRE-EXISTING VALUES.
   // A Java counterpart will be generated for this enum.
   // GENERATED_JAVA_ENUM_PACKAGE: org.chromium.chrome.browser.infobar
   enum InfoBarIdentifier {
     INVALID = -1,
     TEST_INFOBAR = 0,
     APP_BANNER_INFOBAR_DELEGATE_ANDROID = 1,
     APP_BANNER_INFOBAR_DELEGATE_DESKTOP = 2,
-    ANDROID_DOWNLOAD_MANAGER_OVERWRITE_INFOBAR_DELEGATE = 3,
-    CHROME_DOWNLOAD_MANAGER_OVERWRITE_INFOBAR_DELEGATE = 4,
+    ANDROID_DOWNLOAD_MANAGER_DUPLICATE_INFOBAR_DELEGATE = 3,
+    CHROME_DUPLICATE_DOWNLOAD_INFOBAR_DELEGATE = 4,

[Peter Kasting, 2016/11/05 00:26:57]

Is changing these OK, in terms of getting histogram data from the old and new
things mixed together?

[gone, 2016/11/07 19:45:56]

AFAICT they're expanding the scope of the overwrite infobar to catch more
downloads.  It should be fine to reuse the old IDs.

[qinmin, 2016/11/08 00:30:50]

These enums represents how the infobar is generated, from Java side or from
native sode. And since this CL doesn't change the way infobar is generated, so
reusing them should be ok.

     DOWNLOAD_REQUEST_INFOBAR_DELEGATE_ANDROID = 5,
     // Removed: FULLSCREEN_INFOBAR_DELEGATE = 6,
     HUNG_PLUGIN_INFOBAR_DELEGATE = 7,
     HUNG_RENDERER_INFOBAR_DELEGATE = 8,
     MEDIA_STREAM_INFOBAR_DELEGATE_ANDROID = 9,
     MEDIA_THROTTLE_INFOBAR_DELEGATE = 10,
     REQUEST_QUOTA_INFOBAR_DELEGATE = 11,
     DEV_TOOLS_CONFIRM_INFOBAR_DELEGATE = 12,
     EXTENSION_DEV_TOOLS_INFOBAR_DELEGATE = 13,
     INCOGNITO_CONNECTABILITY_INFOBAR_DELEGATE = 14,
@@ skipping 156 matching lines @@
 
   // The ID of the active navigation entry at the time we became owned.
   int nav_entry_id_;
 
   DISALLOW_COPY_AND_ASSIGN(InfoBarDelegate);
 };
 
 }  // namespace infobars
 
 #endif  // COMPONENTS_INFOBARS_CORE_INFOBAR_DELEGATE_H_