components/omnibox/browser/history_url_provider.cc - Issue 2478573004: Convert GURL::{host,path} to GURL::{host_piece,path_piece} for ==.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/omnibox/browser/history_url_provider.cc

Issue 2478573004: Convert GURL::{host,path} to GURL::{host_piece,path_piece} for ==. (Closed)

Patch Set: rebase to #431874 Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/omnibox/browser/history_url_provider.cc

diff --git a/components/omnibox/browser/history_url_provider.cc b/components/omnibox/browser/history_url_provider.cc

index 433c8d1c9a54fd4839979df031aafc9f92d66bfe..08cd7a99355ca7f5927fafbf5afb51dfc6bc7106 100644

--- a/components/omnibox/browser/history_url_provider.cc

+++ b/components/omnibox/browser/history_url_provider.cc

@@ -945,8 +945,8 @@ bool HistoryURLProvider::FixupExactSuggestion(

// which will have empty reference fragments.)

if ((type == UNVISITED_INTRANET) &&

(params->input.type() != metrics::OmniboxInputType::URL) &&

- url.username().empty() && url.password().empty() &&

- url.port().empty() && (url.path() == "/") && url.query().empty() &&

+ url.username().empty() && url.password().empty() && url.port().empty() &&

+ (url.path_piece() == "/") && url.query().empty() &&

(parsed.CountCharactersBefore(url::Parsed::REF, true) !=

parsed.CountCharactersBefore(url::Parsed::REF, false))) {

return false;