Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4007)

Unified Diff: chrome/browser/banners/app_banner_manager.cc

Issue 2478573004: Convert GURL::{host,path} to GURL::{host_piece,path_piece} for ==. (Closed)
Patch Set: rebase to #431874 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chrome_content_browser_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/banners/app_banner_manager.cc
diff --git a/chrome/browser/banners/app_banner_manager.cc b/chrome/browser/banners/app_banner_manager.cc
index 9f98619aff3b33e811638b528b6e92750cd20d52..63aa7b33d06c32de0dd474d3545ab6a7614e42d9 100644
--- a/chrome/browser/banners/app_banner_manager.cc
+++ b/chrome/browser/banners/app_banner_manager.cc
@@ -81,7 +81,8 @@ void AppBannerManager::SetEngagementWeights(double direct_engagement,
bool AppBannerManager::URLsAreForTheSamePage(const GURL& first,
const GURL& second) {
return first.GetWithEmptyPath() == second.GetWithEmptyPath() &&
- first.path() == second.path() && first.query() == second.query();
+ first.path_piece() == second.path_piece() &&
+ first.query_piece() == second.query_piece();
}
void AppBannerManager::RequestAppBanner(const GURL& validated_url,
« no previous file with comments | « no previous file | chrome/browser/chrome_content_browser_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698