Convert GURL::{host,path} to GURL::{host_piece,path_piece} for ==.

extensions/common/extension_urls.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/common/extension_urls.h"
 
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "extensions/common/constants.h"
@@ skipping 65 matching lines @@
                                const std::string& referrer_id) {
   return GURL(base::StringPrintf("%s/report/%s?utm_source=%s",
                                  GetWebstoreLaunchURL().c_str(),
                                  extension_id.c_str(), referrer_id.c_str()));
 }
 
 bool IsWebstoreUpdateUrl(const GURL& update_url) {
   GURL store_url = GetWebstoreUpdateUrl();
   if (update_url == store_url) {
     return true;
   } else {

[Devlin, 2016/11/08 15:55:49]

Totally not your code, but since you're here... :)

Would you mind taking out this else (no need for else after a return) and
removing the parens around the conditions on the line below?

i.e.
if (update_url == store_url)
  return true;
return update_url.host_piece() == store_url.host_piece() &&
       update_url.path_piece() == store_url.path_piece();

[Charlie Harrison, 2016/11/08 16:00:55]

No problem. Done!

-    return (update_url.host() == store_url.host() &&
-            update_url.path() == store_url.path());
+    return (update_url.host_piece() == store_url.host_piece() &&
+            update_url.path_piece() == store_url.path_piece());
   }
 }
 
 bool IsBlacklistUpdateUrl(const GURL& url) {
   extensions::ExtensionsClient* client = extensions::ExtensionsClient::Get();
   if (client)
     return client->IsBlacklistUpdateURL(url);
   return false;
 }
 
 }  // namespace extension_urls