third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h - Issue 2478573002: Make removeChild, parserRemoveChild and removeChildren more consistent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h

Issue 2478573002: Make removeChild, parserRemoveChild and removeChildren more consistent. (Closed)

Patch Set: SubframeLoadingDisabler (oldChild) Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h b/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h

index b61ffb25206fd1799c28b05b3e3d628c33e1c1a9..456979e261e171be9a735f262673059645025f18 100644

--- a/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h

@@ -132,7 +132,9 @@ class SubframeLoadingDisabler {

disabledSubtreeRoots().add(m_root);

}

- ~SubframeLoadingDisabler() {

+ ~SubframeLoadingDisabler() { release(); }

+ void release() {

if (m_root)

disabledSubtreeRoots().remove(m_root);

}