Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: third_party/WebKit/Source/core/dom/ContainerNode.h

Issue 2478573002: Make removeChild, parserRemoveChild and removeChildren more consistent. (Closed)
Patch Set: SubframeLoadingDisabler (oldChild) Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011, 2013 Apple Inc. All 5 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011, 2013 Apple Inc. All
6 * rights reserved. 6 * rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 333 matching lines...) Expand 10 before | Expand all | Expand 10 after
344 NodeListsNodeData& ensureNodeLists(); 344 NodeListsNodeData& ensureNodeLists();
345 void removeBetween(Node* previousChild, Node* nextChild, Node& oldChild); 345 void removeBetween(Node* previousChild, Node* nextChild, Node& oldChild);
346 template <typename Functor> 346 template <typename Functor>
347 void insertNodeVector(const NodeVector&, Node* next, const Functor&); 347 void insertNodeVector(const NodeVector&, Node* next, const Functor&);
348 class AdoptAndInsertBefore; 348 class AdoptAndInsertBefore;
349 class AdoptAndAppendChild; 349 class AdoptAndAppendChild;
350 friend class AdoptAndInsertBefore; 350 friend class AdoptAndInsertBefore;
351 friend class AdoptAndAppendChild; 351 friend class AdoptAndAppendChild;
352 void insertBeforeCommon(Node& nextChild, Node& newChild); 352 void insertBeforeCommon(Node& nextChild, Node& newChild);
353 void appendChildCommon(Node& child); 353 void appendChildCommon(Node& child);
354 void willRemoveChildren();
355 void willRemoveChild(Node& child);
356 void removeDetachedChildrenInContainer(ContainerNode&); 354 void removeDetachedChildrenInContainer(ContainerNode&);
357 void addChildNodesToDeletionQueue(Node*&, Node*&, ContainerNode&); 355 void addChildNodesToDeletionQueue(Node*&, Node*&, ContainerNode&);
358 356
359 void notifyNodeInserted(Node&, 357 void notifyNodeInserted(Node&,
360 ChildrenChangeSource = ChildrenChangeSourceAPI); 358 ChildrenChangeSource = ChildrenChangeSourceAPI);
361 void notifyNodeInsertedInternal(Node&, 359 void notifyNodeInsertedInternal(Node&,
362 NodeVector& postInsertionNotificationTargets); 360 NodeVector& postInsertionNotificationTargets);
363 void notifyNodeRemoved(Node&); 361 void notifyNodeRemoved(Node&);
364 362
365 bool hasRestyleFlag(DynamicRestyleFlags mask) const { 363 bool hasRestyleFlag(DynamicRestyleFlags mask) const {
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
459 457
460 inline void getChildNodes(ContainerNode& node, NodeVector& nodes) { 458 inline void getChildNodes(ContainerNode& node, NodeVector& nodes) {
461 DCHECK(!nodes.size()); 459 DCHECK(!nodes.size());
462 for (Node* child = node.firstChild(); child; child = child->nextSibling()) 460 for (Node* child = node.firstChild(); child; child = child->nextSibling())
463 nodes.append(child); 461 nodes.append(child);
464 } 462 }
465 463
466 } // namespace blink 464 } // namespace blink
467 465
468 #endif // ContainerNode_h 466 #endif // ContainerNode_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698