DevTools: Substring autocomplete in Console and StylesSideBar.

third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 WebInspector.JavaScriptAutocomplete = {};
 
 /**
  * @param {!Element} proxyElement
  * @param {!Range} wordRange
  * @param {boolean} force
@@ skipping 226 matching lines @@
    * @return {!Array<string>}
    */
 WebInspector.JavaScriptAutocomplete._completionsForPrefix = function(dotNotation, bracketNotation, expressionString, prefix, properties) {
   if (bracketNotation) {
     if (prefix.length && prefix[0] === '\'')
       var quoteUsed = '\'';
     else
       var quoteUsed = '"';
   }
 
-  var results = [];
+  var caseSensitivePrefix = [];

[lushnikov, 2016/11/03 22:06:51]

let's move this to where we use these

[einbinder, 2016/11/03 23:12:14]

Done.

+  var caseInsensitivePrefix = [];
+  var caseSensitiveAnywhere = [];
+  var caseInsensitiveAnywhere = [];
 
   if (!expressionString) {
     const keywords = [
       'break', 'case', 'catch', 'continue', 'default', 'delete', 'do', 'else', 'finally',
       'for', 'function', 'if', 'in', 'instanceof', 'new', 'return', 'switch', 'this',
       'throw', 'try', 'typeof', 'var', 'void', 'while', 'with'
     ];
     properties = properties.concat(keywords);
   }
 
   properties.sort();
 
   for (var i = 0; i < properties.length; ++i) {
     var property = properties[i];
 
     // Assume that all non-ASCII characters are letters and thus can be used as part of identifier.
     if (dotNotation && !/^[a-zA-Z_$\u008F-\uFFFF][a-zA-Z0-9_$\u008F-\uFFFF]*$/.test(property))
       continue;
 
     if (bracketNotation) {
       if (!/^[0-9]+$/.test(property))
         property = quoteUsed + property.escapeCharacters(quoteUsed + '\\') + quoteUsed;
       property += ']';
     }
 
     if (property.length < prefix.length)
       continue;
-    if (prefix.length && !property.startsWith(prefix))
+    if (prefix.length && property.toLowerCase().indexOf(prefix.toLowerCase()) === -1)
       continue;
+    // Substitute actual newlines with newline characters. @see crbug.com/498421
+    var prop = property.split('\n').join('\\n');
 
-    // Substitute actual newlines with newline characters. @see crbug.com/498421
-    results.push(property.split('\n').join('\\n'));
+    if (property.startsWith(prefix))
+      caseSensitivePrefix.push(prop);
+    else if (property.toLowerCase().startsWith(prefix.toLowerCase()))
+      caseInsensitivePrefix.push(prop);
+    else if (property.indexOf(prefix) !== -1)
+      caseSensitiveAnywhere.push(prop);
+    else
+      caseInsensitiveAnywhere.push(prop);
   }

[lushnikov, 2016/11/03 22:06:51]

I'm not convinced about JS case-insensetive autocomplete. But we can give it a
shot

[einbinder, 2016/11/03 23:12:14]

Yay!

-  return results;
+  return caseSensitivePrefix.concat(caseInsensitivePrefix).concat(caseSensitiveAnywhere).concat(caseInsensitiveAnywhere);
 };