Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Unified Diff: components/policy/core/common/registry_dict_win_unittest.cc

Issue 2478503002: Enable non-sequential entries when loading registry lists. (Closed)
Patch Set: Validate that the key is numerical. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/policy/core/common/registry_dict_win.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/policy/core/common/registry_dict_win_unittest.cc
diff --git a/components/policy/core/common/registry_dict_win_unittest.cc b/components/policy/core/common/registry_dict_win_unittest.cc
index ac4d79cc91d0c8d84e128fcd6f94efdf19553d48..0d326dd590d2844846706c3abf44422dd96c7260 100644
--- a/components/policy/core/common/registry_dict_win_unittest.cc
+++ b/components/policy/core/common/registry_dict_win_unittest.cc
@@ -222,7 +222,8 @@ TEST(RegistryDictTest, ConvertToJSON) {
" \"string-to-int\": { \"type\": \"integer\" },"
" \"string-to-dict\": { \"type\": \"object\" }"
" }"
- "}", &error);
+ "}",
+ &error);
ASSERT_TRUE(schema.valid()) << error;
std::unique_ptr<base::Value> actual(test_dict.ConvertToJSON(schema));
@@ -251,6 +252,42 @@ TEST(RegistryDictTest, ConvertToJSON) {
EXPECT_TRUE(base::Value::Equals(actual.get(), &expected));
}
+TEST(RegistryDictTest, NonSequentialConvertToJSON) {
+ RegistryDict test_dict;
+
+ std::unique_ptr<RegistryDict> list(new RegistryDict());
+ list->SetValue("1", base::StringValue("1").CreateDeepCopy());
+ list->SetValue("2", base::StringValue("2").CreateDeepCopy());
+ list->SetValue("THREE", base::StringValue("3").CreateDeepCopy());
+ list->SetValue("4", base::StringValue("4").CreateDeepCopy());
+ test_dict.SetKey("dict-to-list", std::move(list));
+
+ std::string error;
+ Schema schema = Schema::Parse(
+ "{"
+ " \"type\": \"object\","
+ " \"properties\": {"
+ " \"dict-to-list\": {"
+ " \"type\": \"array\","
+ " \"items\": { \"type\": \"string\" }"
+ " }"
+ " }"
+ "}",
+ &error);
+ ASSERT_TRUE(schema.valid()) << error;
+
+ std::unique_ptr<base::Value> actual(test_dict.ConvertToJSON(schema));
+
+ base::DictionaryValue expected;
+ std::unique_ptr<base::ListValue> expected_list(new base::ListValue());
+ expected_list->Append(base::StringValue("1").CreateDeepCopy());
+ expected_list->Append(base::StringValue("2").CreateDeepCopy());
+ expected_list->Append(base::StringValue("4").CreateDeepCopy());
+ expected.Set("dict-to-list", std::move(expected_list));
+
+ EXPECT_TRUE(base::Value::Equals(actual.get(), &expected));
+}
+
TEST(RegistryDictTest, KeyValueNameClashes) {
RegistryDict test_dict;
« no previous file with comments | « components/policy/core/common/registry_dict_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698