Enable non-sequential entries when loading registry lists.

components/policy/core/common/registry_dict_win_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/policy/core/common/registry_dict_win.h"
 
 #include <string>
 #include <utility>
 
 #include "base/memory/ptr_util.h"
@@ skipping 204 matching lines @@
       "      \"type\": \"array\","
       "      \"items\": { \"type\": \"string\" }"
       "    },"
       "    \"int-to-bool\": { \"type\": \"boolean\" },"
       "    \"int-to-double\": { \"type\": \"number\" },"
       "    \"string-to-bool\": { \"type\": \"boolean\" },"
       "    \"string-to-double\": { \"type\": \"number\" },"
       "    \"string-to-int\": { \"type\": \"integer\" },"
       "    \"string-to-dict\": { \"type\": \"object\" }"
       "  }"
-      "}", &error);
+      "}",
+      &error);

[Georges Khalil, 2016/11/03 16:04:31]

Result of git cl format.

   ASSERT_TRUE(schema.valid()) << error;
 
   std::unique_ptr<base::Value> actual(test_dict.ConvertToJSON(schema));
 
   base::DictionaryValue expected;
   expected.Set("one", int_value.CreateDeepCopy());
   std::unique_ptr<base::DictionaryValue> expected_subdict(
       new base::DictionaryValue());
   expected_subdict->Set("two", string_value.CreateDeepCopy());
   expected.Set("three", std::move(expected_subdict));
   std::unique_ptr<base::ListValue> expected_list(new base::ListValue());
   expected_list->Append(string_value.CreateDeepCopy());
   expected.Set("dict-to-list", std::move(expected_list));
   expected.Set("int-to-bool", new base::FundamentalValue(true));
   expected.Set("int-to-double", new base::FundamentalValue(42.0));
   expected.Set("string-to-bool", new base::FundamentalValue(false));
   expected.Set("string-to-double", new base::FundamentalValue(0.0));
   expected.Set("string-to-int",
                new base::FundamentalValue(static_cast<int>(0)));
   expected_list.reset(new base::ListValue());
   expected_list->Append(new base::StringValue("value"));
   expected_subdict.reset(new base::DictionaryValue());
   expected_subdict->Set("key", std::move(expected_list));
   expected.Set("string-to-dict", std::move(expected_subdict));
 
   EXPECT_TRUE(base::Value::Equals(actual.get(), &expected));
 }
 
+TEST(RegistryDictTest, NonSequentialConvertToJSON) {
+  RegistryDict test_dict;
+
+  std::unique_ptr<RegistryDict> list(new RegistryDict());
+  list->SetValue("1", base::StringValue("1").CreateDeepCopy());
+  list->SetValue("2", base::StringValue("2").CreateDeepCopy());
+  list->SetValue("4", base::StringValue("4").CreateDeepCopy());
+  test_dict.SetKey("dict-to-list", std::move(list));
+
+  std::string error;
+  Schema schema = Schema::Parse(
+      "{"
+      "  \"type\": \"object\","
+      "  \"properties\": {"
+      "    \"dict-to-list\": {"
+      "      \"type\": \"array\","
+      "      \"items\": { \"type\": \"string\" }"
+      "    }"
+      "  }"
+      "}",
+      &error);
+  ASSERT_TRUE(schema.valid()) << error;
+
+  std::unique_ptr<base::Value> actual(test_dict.ConvertToJSON(schema));
+
+  base::DictionaryValue expected;
+  std::unique_ptr<base::ListValue> expected_list(new base::ListValue());
+  expected_list->Append(base::StringValue("1").CreateDeepCopy());
+  expected_list->Append(base::StringValue("2").CreateDeepCopy());
+  expected_list->Append(base::StringValue("4").CreateDeepCopy());
+  expected.Set("dict-to-list", std::move(expected_list));
+
+  EXPECT_TRUE(base::Value::Equals(actual.get(), &expected));
+}
+
 TEST(RegistryDictTest, KeyValueNameClashes) {
   RegistryDict test_dict;
 
   base::FundamentalValue int_value(42);
   base::StringValue string_value("fortytwo");
 
   test_dict.SetValue("one", int_value.CreateDeepCopy());
   std::unique_ptr<RegistryDict> subdict(new RegistryDict());
   subdict->SetValue("two", string_value.CreateDeepCopy());
   test_dict.SetKey("one", std::move(subdict));
 
   EXPECT_TRUE(base::Value::Equals(&int_value, test_dict.GetValue("one")));
   RegistryDict* actual_subdict = test_dict.GetKey("one");
   ASSERT_TRUE(actual_subdict);
   EXPECT_TRUE(base::Value::Equals(&string_value,
                                   actual_subdict->GetValue("two")));
 }
 
 }  // namespace
 }  // namespace policy