third_party/WebKit/Source/core/layout/LayoutTextControl.cpp - Issue 2478483003: Ignore the percentage value to calculate the logical height of input control

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTextControl.cpp

Issue 2478483003: Ignore the percentage value to calculate the logical height of input control

Patch Set: fix test fails Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutTextControl.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutTextControl.cpp b/third_party/WebKit/Source/core/layout/LayoutTextControl.cpp

index 29f941b8cf885f87093076f0960296b85ecc048a..1105031b58af008f55be93261923e39b70a3c45d 100644

--- a/third_party/WebKit/Source/core/layout/LayoutTextControl.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutTextControl.cpp

@@ -121,8 +121,7 @@ void LayoutTextControl::computeLogicalHeight(

LayoutUnit nonContentHeight = innerEditorBox->borderAndPaddingHeight() +

innerEditorBox->marginHeight();

logicalHeight = computeControlLogicalHeight(

- innerEditorBox->lineHeight(true, HorizontalLine,

- PositionOfInteriorLineBoxes),

+ lineHeight(true, HorizontalLine, PositionOfInteriorLineBoxes),

nonContentHeight);

// We are able to have a horizontal scrollbar if the overflow style is