Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2478463003: Revert of Implement overlay scrollbar fade out for non-composited scrollers. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/FrameView.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp
index 5dd7f8f4e9eec8183e2c0acd1012631aca4bd13d..5c8daac7b6ac0bc4e8d64bb70c4a93f61fe64d14 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp
@@ -300,9 +300,9 @@
// from non-GC'd objects and RootFrameViewport will still have a pointer to
// this class.
if (m_viewportScrollableArea)
- m_viewportScrollableArea->clearScrollableArea();
-
- clearScrollableArea();
+ m_viewportScrollableArea->clearScrollAnimators();
+
+ clearScrollAnimators();
// Destroy |m_autoSizeInfo| as early as possible, to avoid dereferencing
// partially destroyed |this| via |m_autoSizeInfo->m_frameView|.
@@ -1471,7 +1471,6 @@
void FrameView::viewportSizeChanged(bool widthChanged, bool heightChanged) {
DCHECK(widthChanged || heightChanged);
- showOverlayScrollbars();
if (RuntimeEnabledFeatures::rootLayerScrollingEnabled()) {
// The background must be repainted when the FrameView is resized, even if
// the initial containing block does not change (so we can't rely on layout
@@ -2392,8 +2391,6 @@
}
void FrameView::scrollbarVisibilityChanged() {
- // Scrollbar enabled state is set from updateScrollbarGeometry.
- updateScrollbarGeometry();
LayoutViewItem viewItem = layoutViewItem();
if (!viewItem.isNull())
viewItem.clearHitTestCache();
@@ -3607,8 +3604,6 @@
if (scrollDelta.isZero())
return;
- showOverlayScrollbars();
-
if (RuntimeEnabledFeatures::rootLayerScrollingEnabled()) {
// Don't scroll the FrameView!
ASSERT_NOT_REACHED();
@@ -3828,6 +3823,10 @@
if (m_needsScrollbarsUpdate || needsScrollbarReconstruction() ||
scrollOriginChanged())
updateScrollbars();
+}
+
+void FrameView::didChangeScrollbarsHidden() {
+ updateScrollbars();
}
void FrameView::updateScrollbars() {
« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameView.h ('k') | third_party/WebKit/Source/core/frame/RootFrameViewport.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698