Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Issue 2478453002: [Chromecast] Use CdmConfig to create CDM (Closed)

Created:
4 years, 1 month ago by yucliu1
Modified:
4 years, 1 month ago
Reviewers:
slan, halliwell
CC:
chromium-reviews, eme-reviews_chromium.org, lcwu+watch_chromium.org, feature-media-reviews_chromium.org, halliwell+watch_chromium.org, alokp+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Use CdmConfig to create CDM 1. Pass CdmConfig to CreatePlatformBrowserCdm. 2. Add |force_software_crypto| to AddChromecastKeySystems. When enable, cast should use software based OEMCrypto in Widevine. The CL just adds the parameter to the function, corresponding action isn't added. BUG=internal b/31575507 TEST=None Committed: https://crrev.com/83362159d9b9e5116b416391e3c5bfc9fe2a4ee4 Cr-Commit-Position: refs/heads/master@{#429668}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Nit #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -9 lines) Patch
M chromecast/media/cdm/cast_cdm_factory.h View 2 chunks +6 lines, -1 line 0 comments Download
M chromecast/media/cdm/cast_cdm_factory.cc View 2 chunks +4 lines, -5 lines 1 comment Download
M chromecast/renderer/cast_content_renderer_client.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M chromecast/renderer/key_systems_cast.h View 1 chunk +2 lines, -1 line 0 comments Download
M chromecast/renderer/key_systems_cast.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 17 (11 generated)
yucliu1
4 years, 1 month ago (2016-11-03 17:26:55 UTC) #8
halliwell
lgtm % nit https://codereview.chromium.org/2478453002/diff/1/chromecast/renderer/cast_content_renderer_client.cc File chromecast/renderer/cast_content_renderer_client.cc (right): https://codereview.chromium.org/2478453002/diff/1/chromecast/renderer/cast_content_renderer_client.cc#newcode121 chromecast/renderer/cast_content_renderer_client.cc:121: false /* enable_persisten_license_support */, 'persistent'
4 years, 1 month ago (2016-11-03 18:51:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2478453002/20001
4 years, 1 month ago (2016-11-03 18:54:34 UTC) #12
slan
lgtm https://codereview.chromium.org/2478453002/diff/20001/chromecast/media/cdm/cast_cdm_factory.cc File chromecast/media/cdm/cast_cdm_factory.cc (right): https://codereview.chromium.org/2478453002/diff/20001/chromecast/media/cdm/cast_cdm_factory.cc#newcode79 chromecast/media/cdm/cast_cdm_factory.cc:79: scoped_refptr<CastCdm> CastCdmFactory::CreatePlatformBrowserCdm( Unrelated: All references to "Browser" should ...
4 years, 1 month ago (2016-11-03 19:06:53 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-03 19:19:59 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 19:46:52 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/83362159d9b9e5116b416391e3c5bfc9fe2a4ee4
Cr-Commit-Position: refs/heads/master@{#429668}

Powered by Google App Engine
This is Rietveld 408576698