Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: content/common/input/synthetic_pointer_action_params.h

Issue 2478423002: Rename SyntheticPointer to SyntheticPointerDriver (Closed)
Patch Set: rename Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/input/synthetic_pointer_action_params.h
diff --git a/content/common/input/synthetic_pointer_action_params.h b/content/common/input/synthetic_pointer_action_params.h
index 4e51f036b7352174c7fa2573d0d9b0cd090da414..dc6fa500fb11815d456d1e295c7efbf0b01ac994 100644
--- a/content/common/input/synthetic_pointer_action_params.h
+++ b/content/common/input/synthetic_pointer_action_params.h
@@ -21,21 +21,22 @@ namespace content {
struct CONTENT_EXPORT SyntheticPointerActionParams
: public SyntheticGestureParams {
public:
- // Actions are queued up until we receive a PROCESS action, at which point
- // we'll dispatch all queued events. A FINISH action will be received when
- // we reach the end of the action sequence.
+ // All the pointer actions that will be dispatched together will be grouped
+ // in an array. A FINISH action will be received when we reach the end of the
+ // action sequence.
enum class PointerActionType {
NOT_INITIALIZED,
PRESS,
MOVE,
RELEASE,
- PROCESS,
+ IDLE,
FINISH,
POINTER_ACTION_TYPE_MAX = FINISH
};
SyntheticPointerActionParams();
- explicit SyntheticPointerActionParams(PointerActionType type);
+ SyntheticPointerActionParams(PointerActionType action_type,
+ GestureSourceType source_type);
SyntheticPointerActionParams(const SyntheticPointerActionParams& other);
~SyntheticPointerActionParams() override;
@@ -49,9 +50,8 @@ struct CONTENT_EXPORT SyntheticPointerActionParams
}
void set_index(int index) {
- DCHECK(pointer_action_type_ != PointerActionType::PROCESS &&
- pointer_action_type_ != PointerActionType::FINISH);
- // For all mouse pointer actions, the index should always be 0.
+ DCHECK(pointer_action_type_ != PointerActionType::FINISH);
+ // For mouse pointers, the index should always be 0.
DCHECK(gesture_source_type != MOUSE_INPUT || index == 0);
index_ = index;
}
@@ -65,8 +65,8 @@ struct CONTENT_EXPORT SyntheticPointerActionParams
PointerActionType pointer_action_type() const { return pointer_action_type_; }
int index() const {
- DCHECK(pointer_action_type_ != PointerActionType::PROCESS &&
- pointer_action_type_ != PointerActionType::FINISH);
+ DCHECK(pointer_action_type_ != PointerActionType::FINISH);
+ // For mouse pointers, the index should always be 0.
DCHECK(gesture_source_type != MOUSE_INPUT || index_ == 0);
return index_;
}
« no previous file with comments | « content/common/input/input_param_traits_unittest.cc ('k') | content/common/input/synthetic_pointer_action_params.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698