|
|
Chromium Code Reviews|
Created:
4 years, 1 month ago by Ryan Tseng Modified:
4 years, 1 month ago CC:
chromium-reviews, infra-reviews+build_chromium.org Target Ref:
refs/heads/master Project:
build Visibility:
Public. |
DescriptionMove some non-tree closing bots on chromium.android to chromium.android.fyi
These are the builders with about 50% pass rate.
BUG=660180
Committed: https://chromium.googlesource.com/chromium/tools/build/+/254b63d101d5e09990d0d969dcb426af6e0dcf6e
Patch Set 1 #
Total comments: 2
Patch Set 2 : review #Patch Set 3 : Jelly bean tester, master ports #Patch Set 4 : ports update #Patch Set 5 : tests #Patch Set 6 : tests #
Total comments: 2
Patch Set 7 : rebase #Patch Set 8 : Review #
Messages
Total messages: 48 (33 generated)
The CQ bit was checked by hinoka@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/324a5636a5cfdf10)
The CQ bit was checked by hinoka@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-infra-committers". Note that this has nothing to do with OWNERS files.
The CQ bit was checked by hinoka@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
hinoka@chromium.org changed reviewers: + bpastene@chromium.org, jbudorick@chromium.org, stip@chromium.org
ptal. Namely, see if the builders being moved over are the right ones.
https://codereview.chromium.org/2478413002/diff/1/masters/master.chromium.and... File masters/master.chromium.android.fyi/builders.pyl (right): https://codereview.chromium.org/2478413002/diff/1/masters/master.chromium.and... masters/master.chromium.android.fyi/builders.pyl:14: "builders": { This should only move: - L Consumer - L Low-end
https://codereview.chromium.org/2478413002/diff/1/masters/master.chromium.and... File masters/master.chromium.android.fyi/builders.pyl (right): https://codereview.chromium.org/2478413002/diff/1/masters/master.chromium.and... masters/master.chromium.android.fyi/builders.pyl:14: "builders": { On 2016/11/04 23:30:04, jbudorick wrote: > This should only move: > - L Consumer > - L Low-end Only two? The rest of them look pretty red to me too.
On 2016/11/04 23:43:45, hinoka wrote: > https://codereview.chromium.org/2478413002/diff/1/masters/master.chromium.and... > File masters/master.chromium.android.fyi/builders.pyl (right): > > https://codereview.chromium.org/2478413002/diff/1/masters/master.chromium.and... > masters/master.chromium.android.fyi/builders.pyl:14: "builders": { > On 2016/11/04 23:30:04, jbudorick wrote: > > This should only move: > > - L Consumer > > - L Low-end > > Only two? The rest of them look pretty red to me too. They are, but they need to be fixed rather than FYI'ed.
The CQ bit was checked by hinoka@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/324ab0ee3849db10)
On 2016/11/04 23:49:35, jbudorick wrote: > On 2016/11/04 23:43:45, hinoka wrote: > > > https://codereview.chromium.org/2478413002/diff/1/masters/master.chromium.and... > > File masters/master.chromium.android.fyi/builders.pyl (right): > > > > > https://codereview.chromium.org/2478413002/diff/1/masters/master.chromium.and... > > masters/master.chromium.android.fyi/builders.pyl:14: "builders": { > > On 2016/11/04 23:30:04, jbudorick wrote: > > > This should only move: > > > - L Consumer > > > - L Low-end > > > > Only two? The rest of them look pretty red to me too. > > They are, but they need to be fixed rather than FYI'ed. As Ben pointed out, JB should move over to FYI, too.
The CQ bit was checked by hinoka@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by hinoka@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by hinoka@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/3263b2fbecb15610)
The CQ bit was checked by hinoka@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
ptal again there will be a separate CL to get the triggering to work. Until then the FYI builders will be red.
Is there a plan wrt all the needed recipe changes? The bots will also need to be removed from https://chromium.googlesource.com/chromium/tools/build/+/master/scripts/slave... prior to master restart. https://codereview.chromium.org/2478413002/diff/100001/masters/master.chromiu... File masters/master.chromium.android/builders.pyl (right): https://codereview.chromium.org/2478413002/diff/100001/masters/master.chromiu... masters/master.chromium.android/builders.pyl:15: "Lollipop Tablet Tester": { nit: Could you re-alphabetize these please?
rebase
The CQ bit was checked by hinoka@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Recipe changes here: https://codereview.chromium.org/2491033005/ Seperate becase they have to be committed at master restart time instead
The CQ bit was checked by hinoka@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
ptal now https://codereview.chromium.org/2478413002/diff/100001/masters/master.chromiu... File masters/master.chromium.android/builders.pyl (right): https://codereview.chromium.org/2478413002/diff/100001/masters/master.chromiu... masters/master.chromium.android/builders.pyl:15: "Lollipop Tablet Tester": { On 2016/11/10 01:38:50, bpastene wrote: > nit: Could you re-alphabetize these please? Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by hinoka@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Move some non-tree closing bots on chromium.android to chromium.android.fyi These are the builders with about 50% pass rate. BUG=660180 ========== to ========== Move some non-tree closing bots on chromium.android to chromium.android.fyi These are the builders with about 50% pass rate. BUG=660180 Committed: https://chromium.googlesource.com/chromium/tools/build/+/254b63d101d5e09990d0... ==========
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as https://chromium.googlesource.com/chromium/tools/build/+/254b63d101d5e09990d0... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
