Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2478413002: Move some non-tree closing bots on chromium.android to chromium.android.fyi (Closed)

Created:
4 years, 1 month ago by Ryan Tseng
Modified:
4 years, 1 month ago
CC:
chromium-reviews, infra-reviews+build_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Move some non-tree closing bots on chromium.android to chromium.android.fyi These are the builders with about 50% pass rate. BUG=660180 Committed: https://chromium.googlesource.com/chromium/tools/build/+/254b63d101d5e09990d0d969dcb426af6e0dcf6e

Patch Set 1 #

Total comments: 2

Patch Set 2 : review #

Patch Set 3 : Jelly bean tester, master ports #

Patch Set 4 : ports update #

Patch Set 5 : tests #

Patch Set 6 : tests #

Total comments: 2

Patch Set 7 : rebase #

Patch Set 8 : Review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -62 lines) Patch
A masters/master.chromium.android.fyi/Makefile View 1 2 3 4 5 6 1 chunk +12 lines, -0 lines 0 comments Download
A masters/master.chromium.android.fyi/builders.pyl View 1 2 1 chunk +75 lines, -0 lines 0 comments Download
A masters/master.chromium.android.fyi/master.cfg View 1 2 3 4 5 6 1 chunk +26 lines, -0 lines 0 comments Download
A + masters/master.chromium.android.fyi/master_site_config.py View 1 2 3 1 chunk +7 lines, -7 lines 0 comments Download
M masters/master.chromium.android/builders.pyl View 1 2 3 4 5 6 7 4 chunks +0 lines, -54 lines 0 comments Download
M masters/master.chromium.android/master_site_config.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/masters_test.py View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 48 (33 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2478413002/1
4 years, 1 month ago (2016-11-04 23:02:39 UTC) #6
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 1 month ago (2016-11-04 23:02:41 UTC) #8
hinoka
ptal. Namely, see if the builders being moved over are the right ones.
4 years, 1 month ago (2016-11-04 23:26:21 UTC) #12
jbudorick
https://codereview.chromium.org/2478413002/diff/1/masters/master.chromium.android.fyi/builders.pyl File masters/master.chromium.android.fyi/builders.pyl (right): https://codereview.chromium.org/2478413002/diff/1/masters/master.chromium.android.fyi/builders.pyl#newcode14 masters/master.chromium.android.fyi/builders.pyl:14: "builders": { This should only move: - L Consumer ...
4 years, 1 month ago (2016-11-04 23:30:04 UTC) #13
hinoka
https://codereview.chromium.org/2478413002/diff/1/masters/master.chromium.android.fyi/builders.pyl File masters/master.chromium.android.fyi/builders.pyl (right): https://codereview.chromium.org/2478413002/diff/1/masters/master.chromium.android.fyi/builders.pyl#newcode14 masters/master.chromium.android.fyi/builders.pyl:14: "builders": { On 2016/11/04 23:30:04, jbudorick wrote: > This ...
4 years, 1 month ago (2016-11-04 23:43:45 UTC) #14
jbudorick
On 2016/11/04 23:43:45, hinoka wrote: > https://codereview.chromium.org/2478413002/diff/1/masters/master.chromium.android.fyi/builders.pyl > File masters/master.chromium.android.fyi/builders.pyl (right): > > https://codereview.chromium.org/2478413002/diff/1/masters/master.chromium.android.fyi/builders.pyl#newcode14 > ...
4 years, 1 month ago (2016-11-04 23:49:35 UTC) #15
jbudorick
On 2016/11/04 23:49:35, jbudorick wrote: > On 2016/11/04 23:43:45, hinoka wrote: > > > https://codereview.chromium.org/2478413002/diff/1/masters/master.chromium.android.fyi/builders.pyl ...
4 years, 1 month ago (2016-11-09 20:13:57 UTC) #20
hinoka
ptal again there will be a separate CL to get the triggering to work. Until ...
4 years, 1 month ago (2016-11-09 22:59:43 UTC) #33
bpastene
Is there a plan wrt all the needed recipe changes? The bots will also need ...
4 years, 1 month ago (2016-11-10 01:38:51 UTC) #34
Ryan Tseng
rebase
4 years, 1 month ago (2016-11-11 20:33:53 UTC) #35
hinoka
Recipe changes here: https://codereview.chromium.org/2491033005/ Seperate becase they have to be committed at master restart time ...
4 years, 1 month ago (2016-11-11 20:34:53 UTC) #38
hinoka
ptal now https://codereview.chromium.org/2478413002/diff/100001/masters/master.chromium.android/builders.pyl File masters/master.chromium.android/builders.pyl (right): https://codereview.chromium.org/2478413002/diff/100001/masters/master.chromium.android/builders.pyl#newcode15 masters/master.chromium.android/builders.pyl:15: "Lollipop Tablet Tester": { On 2016/11/10 01:38:50, ...
4 years, 1 month ago (2016-11-11 20:39:14 UTC) #41
ghost stip (do not use)
lgtm
4 years, 1 month ago (2016-11-11 21:34:02 UTC) #44
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2478413002/140001
4 years, 1 month ago (2016-11-11 21:35:26 UTC) #46
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 21:46:28 UTC) #48
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/tools/build/+/254b63d101d5e09990d0...

Powered by Google App Engine
This is Rietveld 408576698