Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Issue 2478383003: Remove isBreakValid for Emoji sequences (Closed)

Created:
4 years, 1 month ago by jungshik at Google
Modified:
4 years, 1 month ago
Reviewers:
drott
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove isBreakValid for Emoji sequences isBreakValid was added to avoid wrap lines in the middle of an Emoji sequence (ZWJ-linked or Emoji base + Emoji modifier), but it's not necessary any more now that ICU was updated to 58.1 that handles Emoji sequences correctly. BUG=593263 TEST=blink_platform_unittest --gtest_filter=*BreakItera* Committed: https://crrev.com/62d66e352097e36b6f7846b68f9e0b05eb9598ad Cr-Commit-Position: refs/heads/master@{#430691}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -62 lines) Patch
M third_party/WebKit/Source/platform/text/TextBreakIterator.cpp View 3 chunks +2 lines, -54 lines 0 comments Download
M third_party/WebKit/Source/platform/text/TextBreakIteratorTest.cpp View 2 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
jungshik at Google
Dominik, can you take a look? Thanks
4 years, 1 month ago (2016-11-05 09:12:07 UTC) #4
drott
Fantastic, so happy we can get rid of this! LGTM assuming that the test strings ...
4 years, 1 month ago (2016-11-08 09:12:55 UTC) #7
drott
Thanks for taking care of this issue.
4 years, 1 month ago (2016-11-08 09:13:15 UTC) #8
jungshik at Google
On 2016/11/08 09:12:55, drott wrote: > Fantastic, so happy we can get rid of this! ...
4 years, 1 month ago (2016-11-08 18:17:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2478383003/1
4 years, 1 month ago (2016-11-08 18:18:14 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 19:55:48 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 20:10:49 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/62d66e352097e36b6f7846b68f9e0b05eb9598ad
Cr-Commit-Position: refs/heads/master@{#430691}

Powered by Google App Engine
This is Rietveld 408576698