Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 2478363003: PerformanceMonitor: do not leak performance objects through the monitor. (Closed)

Created:
4 years, 1 month ago by pfeldman
Modified:
4 years, 1 month ago
Reviewers:
caseq, panicker
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PerformanceMonitor: do not leak performance objects through the monitor. BUG=663260 Committed: https://crrev.com/6965123c13447fbeebc5824318af521dc682999d Cr-Commit-Position: refs/heads/master@{#430821}

Patch Set 1 #

Patch Set 2 : rebaselined #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp View 1 2 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/timing/Performance.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/timing/Performance.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
pfeldman
4 years, 1 month ago (2016-11-04 23:12:04 UTC) #2
caseq
lgtm
4 years, 1 month ago (2016-11-04 23:13:00 UTC) #3
panicker
lgtm
4 years, 1 month ago (2016-11-04 23:16:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2478363003/1
4 years, 1 month ago (2016-11-07 19:54:19 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/102124) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 1 month ago (2016-11-07 19:57:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2478363003/20001
4 years, 1 month ago (2016-11-08 19:10:34 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/327965)
4 years, 1 month ago (2016-11-09 00:08:54 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2478363003/20001
4 years, 1 month ago (2016-11-09 00:18:44 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-09 01:53:10 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 02:01:33 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6965123c13447fbeebc5824318af521dc682999d
Cr-Commit-Position: refs/heads/master@{#430821}

Powered by Google App Engine
This is Rietveld 408576698