Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Issue 2478343002: Removing the ChildProcessHostMsg_SyncAllocateSharedMemory IPC message. (Closed)

Created:
4 years, 1 month ago by Jay Civelli
Modified:
4 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replacing the ChildProcessHostMsg_SyncAllocateSharedMemory IPC message with a Mojo shared buffer. Mojo shared buffers automatically delegate to a privileged process using an internal sync IPC if necessary when instanciated, hence the simplification here. BUG=612500 Committed: https://crrev.com/f42b5afcda825dbd4d9e278082c24578866d3c31 Cr-Commit-Position: refs/heads/master@{#431130}

Patch Set 1 #

Patch Set 2 : Removed debug log. #

Patch Set 3 : Synced #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -82 lines) Patch
M content/browser/renderer_host/render_message_filter.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 2 chunks +3 lines, -24 lines 0 comments Download
M content/child/child_thread_impl.cc View 1 2 chunks +16 lines, -18 lines 0 comments Download
M content/common/child_process_host_impl.h View 1 2 2 chunks +0 lines, -7 lines 0 comments Download
M content/common/child_process_host_impl.cc View 1 2 3 chunks +3 lines, -24 lines 0 comments Download
M content/common/child_process_messages.h View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 36 (24 generated)
Jay Civelli
4 years, 1 month ago (2016-11-07 20:24:44 UTC) #10
Ken Rockot(use gerrit already)
lgtm
4 years, 1 month ago (2016-11-07 20:30:25 UTC) #11
Jay Civelli
Adding @nasko as OWNER reviewer. Thanks.
4 years, 1 month ago (2016-11-08 00:48:42 UTC) #16
Ken Rockot(use gerrit already)
On 2016/11/08 at 00:48:42, jcivelli wrote: > Adding @nasko as OWNER reviewer. > > > ...
4 years, 1 month ago (2016-11-08 00:52:17 UTC) #17
Jay Civelli
On 2016/11/08 00:52:17, Ken Rockot wrote: > On 2016/11/08 at 00:48:42, jcivelli wrote: > > ...
4 years, 1 month ago (2016-11-08 00:56:56 UTC) #19
nasko
LGTM
4 years, 1 month ago (2016-11-08 21:49:42 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2478343002/20001
4 years, 1 month ago (2016-11-09 22:02:42 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-generic_chromium_compile_only_ng/builds/232263) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 1 month ago (2016-11-10 00:04:57 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2478343002/40001
4 years, 1 month ago (2016-11-10 01:38:18 UTC) #31
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-10 01:43:13 UTC) #33
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/f42b5afcda825dbd4d9e278082c24578866d3c31 Cr-Commit-Position: refs/heads/master@{#431130}
4 years, 1 month ago (2016-11-10 01:51:39 UTC) #35
vabr (Chromium)
4 years, 1 month ago (2016-11-10 09:15:58 UTC) #36
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2491763003/ by vabr@chromium.org.

The reason for reverting is: This is causing crashes in
fast/hidpi/scrollbar-appearance-increase-device-scale-factor.html, more info in
http://crbug.com/612500#c71..

Powered by Google App Engine
This is Rietveld 408576698