Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1488)

Unified Diff: chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc

Issue 2478323003: Ozone Linux: Fix linker errors in interactive_ui_tests (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc
diff --git a/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc b/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc
index 10d80815a0cfdcafb4aebf88a3522c4285ead267..a4ee3a4482363c599d066eb8db12bb56f23e7aac 100644
--- a/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc
+++ b/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc
@@ -309,7 +309,13 @@ class TestNativeBrowserFrameFactory : public NativeBrowserFrameFactory {
NativeBrowserFrame* Create(BrowserFrame* browser_frame,
BrowserView* browser_view) override {
+#if defined(USE_OZONE)
sky 2016/11/04 21:33:02 Without TestDesktopBrowserFrameAura TabDragCapture
Tom (Use chromium acct) 2016/11/04 21:54:21 That would not fix the linker error. The error is
sky 2016/11/04 23:15:39 If that's the case, don't you need an ifdef around
Tom (Use chromium acct) 2016/11/04 23:34:05 Oops, I meant there's no CreateBrowserDesktopWindo
+ NOTIMPLEMENTED()
+ << "For Ozone builds, only --mash launch is supported for now.";
+ return nullptr;
+#else
return new TestDesktopBrowserFrameAura(browser_frame, browser_view);
+#endif
}
private:
« no previous file with comments | « no previous file | chrome/test/base/interactive_ui_tests_main.cc » ('j') | chrome/test/base/interactive_ui_tests_main.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698