src/builtins/ppc/builtins-ppc.cc - Issue 2478323002: [compiler] Fix flipped boolean checks in marked tier-up

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/builtins/ppc/builtins-ppc.cc

Issue 2478323002: [compiler] Fix flipped boolean checks in marked tier-up (Closed)

Patch Set: Fix ARM/PPC assembly to use tst correctly Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/builtins/ppc/builtins-ppc.cc

diff --git a/src/builtins/ppc/builtins-ppc.cc b/src/builtins/ppc/builtins-ppc.cc

index 678287f37b8adab7b28af486421880b33dcaeb42..52df740212203a685f5095c0a067e3cc3f1be7b2 100644

--- a/src/builtins/ppc/builtins-ppc.cc

+++ b/src/builtins/ppc/builtins-ppc.cc

@@ -1506,7 +1506,7 @@ void Builtins::Generate_CompileLazy(MacroAssembler* masm) {

__ lbz(r8, FieldMemOperand(entry,

SharedFunctionInfo::kMarkedForTierUpByteOffset));

__ TestBit(r8, SharedFunctionInfo::kMarkedForTierUpBitWithinByte, r0);

- __ beq(&gotta_call_runtime);

+ __ bne(&gotta_call_runtime);

// Is the full code valid?

__ LoadP(entry, FieldMemOperand(entry, SharedFunctionInfo::kCodeOffset));

__ lwz(r8, FieldMemOperand(entry, Code::kFlagsOffset));

« no previous file with comments | « src/builtins/arm/builtins-arm.cc ('k') | src/compiler.cc » ('j') | no next file with comments »