[compiler] Fix flipped boolean checks in marked tier-up

test/mjsunit/shared-function-tier-up-default.js

+// Copyright 2016 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+//
+// Flags: --mark-shared-functions-for-tier-up --allow-natives-syntax --no-ignition-staging --no-turbo

[rmcilroy, 2016/11/07 10:17:46]

This is not really default since it's --no-ignition-staging and --no-turbo.
Could you just have a single test and just use %BaselineFunctionOnNextCall to
control whether we are optimizing or baselining (with suitable checks that we
either remain in an appropriate OptimizationStatus (e.g., don't do anything or
tier up to baseline depending on the flags)?

[Leszek Swirski, 2016/11/11 10:13:29]

I tried putting this in a single test, but it ended up being very messy (having
to effectively hack in checks for these various flags because e.g. we don't
baseline when tiering up ignition->turbo). Three tests feels cleaner, but I did
add extra guards against always opt and invalid optimization statuses, as well
as a new optimization status for interpreted code.

+
+(function f() {
+  var sum = 0;
+  var i = 0;
+  for (var i = 0; i < 3; ++i) {
+    var g = function(x) {
+      return 2 * x;
+    }
+    sum += g(i);
+
+    if (i == 1) {
+      // Run twice (i = 0, 1), then tier-up.
+      %OptimizeFunctionOnNextCall(g);
+    } else if (i == 2) {
+      // Tier-up at i = 2 should go up to crankshaft.
+      assertEquals(1, %GetOptimizationStatus(g));
+    }
+  }
+})()