Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/builtins/arm/builtins-arm.cc

Issue 2478323002: [compiler] Fix flipped boolean checks in marked tier-up (Closed)
Patch Set: Fix ARM/PPC assembly to use tst correctly Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/builtins/ppc/builtins-ppc.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM 5 #if V8_TARGET_ARCH_ARM
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/debug/debug.h" 8 #include "src/debug/debug.h"
9 #include "src/deoptimizer.h" 9 #include "src/deoptimizer.h"
10 #include "src/full-codegen/full-codegen.h" 10 #include "src/full-codegen/full-codegen.h"
(...skipping 1466 matching lines...) Expand 10 before | Expand all | Expand 10 after
1477 __ bind(&try_shared); 1477 __ bind(&try_shared);
1478 __ pop(closure); 1478 __ pop(closure);
1479 __ pop(new_target); 1479 __ pop(new_target);
1480 __ pop(argument_count); 1480 __ pop(argument_count);
1481 __ ldr(entry, 1481 __ ldr(entry,
1482 FieldMemOperand(closure, JSFunction::kSharedFunctionInfoOffset)); 1482 FieldMemOperand(closure, JSFunction::kSharedFunctionInfoOffset));
1483 // Is the shared function marked for tier up? 1483 // Is the shared function marked for tier up?
1484 __ ldrb(r5, FieldMemOperand(entry, 1484 __ ldrb(r5, FieldMemOperand(entry,
1485 SharedFunctionInfo::kMarkedForTierUpByteOffset)); 1485 SharedFunctionInfo::kMarkedForTierUpByteOffset));
1486 __ tst(r5, Operand(1 << SharedFunctionInfo::kMarkedForTierUpBitWithinByte)); 1486 __ tst(r5, Operand(1 << SharedFunctionInfo::kMarkedForTierUpBitWithinByte));
1487 __ b(eq, &gotta_call_runtime_no_stack); 1487 __ b(ne, &gotta_call_runtime_no_stack);
1488 // Is the full code valid? 1488 // Is the full code valid?
1489 __ ldr(entry, FieldMemOperand(entry, SharedFunctionInfo::kCodeOffset)); 1489 __ ldr(entry, FieldMemOperand(entry, SharedFunctionInfo::kCodeOffset));
1490 __ ldr(r5, FieldMemOperand(entry, Code::kFlagsOffset)); 1490 __ ldr(r5, FieldMemOperand(entry, Code::kFlagsOffset));
1491 __ and_(r5, r5, Operand(Code::KindField::kMask)); 1491 __ and_(r5, r5, Operand(Code::KindField::kMask));
1492 __ mov(r5, Operand(r5, LSR, Code::KindField::kShift)); 1492 __ mov(r5, Operand(r5, LSR, Code::KindField::kShift));
1493 __ cmp(r5, Operand(Code::BUILTIN)); 1493 __ cmp(r5, Operand(Code::BUILTIN));
1494 __ b(eq, &gotta_call_runtime_no_stack); 1494 __ b(eq, &gotta_call_runtime_no_stack);
1495 // Yes, install the full code. 1495 // Yes, install the full code.
1496 __ add(entry, entry, Operand(Code::kHeaderSize - kHeapObjectTag)); 1496 __ add(entry, entry, Operand(Code::kHeaderSize - kHeapObjectTag));
1497 __ str(entry, FieldMemOperand(closure, JSFunction::kCodeEntryOffset)); 1497 __ str(entry, FieldMemOperand(closure, JSFunction::kCodeEntryOffset));
(...skipping 1412 matching lines...) Expand 10 before | Expand all | Expand 10 after
2910 __ bkpt(0); 2910 __ bkpt(0);
2911 } 2911 }
2912 } 2912 }
2913 2913
2914 #undef __ 2914 #undef __
2915 2915
2916 } // namespace internal 2916 } // namespace internal
2917 } // namespace v8 2917 } // namespace v8
2918 2918
2919 #endif // V8_TARGET_ARCH_ARM 2919 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/builtins/ppc/builtins-ppc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698