Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 2478313006: Revert of Roll recipe dependencies (trivial). (Closed)

Created:
4 years, 1 month ago by agable
Modified:
4 years, 1 month ago
CC:
chromium-reviews, infra-reviews+build_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Roll recipe dependencies (trivial). (patchset #1 id:1 of https://codereview.chromium.org/2477043003/ ) Reason for revert: This appears to have broken the build_presubmit recipe. First failure here: https://luci-milo.appspot.com/swarming/task/324a4aa079264b10 Original issue's description: > Roll recipe dependencies (trivial). > > This is an automated CL created by the recipe roller. This CL rolls recipe > changes from upstream projects (e.g. depot_tools) into downstream projects > (e.g. tools/build). > > > More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug > (or complain) > > depot_tools: > https://crrev.com/27b7a139de8ad92d094e6857807c02cb7fef5b74 Roll recipe dependencies (trivial). (recipe-roller@chromium.org) > https://crrev.com/e0b205e884ca787fb96c29799ac0260e6a07d84a Roll recipe dependencies (nontrivial). (recipe-roller@chromium.org) > https://crrev.com/8c4faee3fa2bd4153a538228a59d0f8aa460e16a Roll recipe dependencies (trivial). (recipe-roller@chromium.org) > https://crrev.com/39cec0e77bd8b70ee18cc3f47ebae9676e76c12f Disable coverage in depot_tools tests. (iannucci@chromium.org) > https://crrev.com/a5025f62b8833c60f8421f465edb3538308eac7f Roll recipe dependencies (trivial). (recipe-roller@chromium.org) > https://crrev.com/8c5a353e63ac55ace8f761478f085b3be5e65fc2 Implement and test git cl try for Gerrit. (tandrii@chromium.org) > https://crrev.com/b8b5aaea9217f0a2e0b9a48bfa6e6fc054d74d23 fix swarmbucket infra path (nodir@chromium.org) > https://crrev.com/3ac992bd93a00398ca0f1036ba349381a7aa3c3e Roll recipe dependencies (trivial). (recipe-roller@chromium.org) > recipe_engine: > https://crrev.com/2ecaa8b5944f016f6bda5cbe93ec6f54e8ead4fb Delete tryserver_gerrit and its old properties. (tandrii@chromium.org) > https://crrev.com/fabbc26432e0ba2e5492e01640722eb4641519c9 Add exit status proto (martiniss@chromium.org) > https://crrev.com/2c474706779466f2e18e83a632f6d6debf63787f Fix issue overriding bug properties.test_api.tryserver for Gerrit. (tandrii@chromium.org) > https://crrev.com/6b5af03500f8ab57a2905d11af2690de990961bd Remove unused --bootstrap-script option. (iannucci@chromium.org) > https://crrev.com/0e5c8ab8680b51dfe55745ade2b26a7aa15e0f53 Add LogDog environment variables to whitelist. (dnj@chromium.org) > https://crrev.com/6d04a2a25f68b37024e9d45ff32252e4d4903664 Revert of Delete tryserver_gerrit and its old properties. (patchset #1 id:1 of https://codereview.chromium.org/2464673002/ ) (martiniss@chromium.org) > > TBR=martiniss@chromium.org,phajdan.jr@chromium.org > > Recipe-Tryjob-Bypass-Reason: Autoroller > Bugdroid-Send-Email: False > Committed: https://chromium.googlesource.com/chromium/tools/build/+/60d41cb475798dc075258ab0f3508c564589c092 TBR=martiniss@chromium.org,phajdan.jr@chromium.org,recipe-roller@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://chromium.googlesource.com/chromium/tools/build/+/33982e022c21a821bfa3e340bde30974e6ffa5fa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M infra/config/recipes.cfg View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
agable
Created Revert of Roll recipe dependencies (trivial).
4 years, 1 month ago (2016-11-04 22:50:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2478313006/1
4 years, 1 month ago (2016-11-04 22:50:38 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/33982e022c21a821bfa3e340bde30974e6ffa5fa
4 years, 1 month ago (2016-11-04 22:50:44 UTC) #5
agable
4 years, 1 month ago (2016-11-04 22:51:53 UTC) #6
Message was sent while issue was closed.
Whoops, actual first failure here:
https://luci-milo.appspot.com/swarming/task/324a4e70d3fab410

Powered by Google App Engine
This is Rietveld 408576698