Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: third_party/WebKit/Source/modules/webaudio/WaveShaperDSPKernel.cpp

Issue 2478283003: Use kRenderQuantumFrames in more places (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/WaveShaperDSPKernel.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/WaveShaperDSPKernel.cpp b/third_party/WebKit/Source/modules/webaudio/WaveShaperDSPKernel.cpp
index f6ee2945ba3ecda28f905c7358dc53e29613d911..684f189a5164918307e61add86ce07346c06c770 100644
--- a/third_party/WebKit/Source/modules/webaudio/WaveShaperDSPKernel.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/WaveShaperDSPKernel.cpp
@@ -24,12 +24,12 @@
*/
#include "modules/webaudio/WaveShaperDSPKernel.h"
+
+#include "platform/audio/AudioUtilities.h"
#include "wtf/PtrUtil.h"
#include "wtf/Threading.h"
#include <algorithm>
-const unsigned RenderingQuantum = 128;
-
namespace blink {
WaveShaperDSPKernel::WaveShaperDSPKernel(WaveShaperProcessor* processor)
@@ -40,12 +40,18 @@ WaveShaperDSPKernel::WaveShaperDSPKernel(WaveShaperProcessor* processor)
void WaveShaperDSPKernel::lazyInitializeOversampling() {
if (!m_tempBuffer) {
- m_tempBuffer = wrapUnique(new AudioFloatArray(RenderingQuantum * 2));
- m_tempBuffer2 = wrapUnique(new AudioFloatArray(RenderingQuantum * 4));
- m_upSampler = wrapUnique(new UpSampler(RenderingQuantum));
- m_downSampler = wrapUnique(new DownSampler(RenderingQuantum * 2));
- m_upSampler2 = wrapUnique(new UpSampler(RenderingQuantum * 2));
- m_downSampler2 = wrapUnique(new DownSampler(RenderingQuantum * 4));
+ m_tempBuffer = wrapUnique(
+ new AudioFloatArray(AudioUtilities::kRenderQuantumFrames * 2));
+ m_tempBuffer2 = wrapUnique(
+ new AudioFloatArray(AudioUtilities::kRenderQuantumFrames * 4));
+ m_upSampler =
+ wrapUnique(new UpSampler(AudioUtilities::kRenderQuantumFrames));
+ m_downSampler =
+ wrapUnique(new DownSampler(AudioUtilities::kRenderQuantumFrames * 2));
+ m_upSampler2 =
+ wrapUnique(new UpSampler(AudioUtilities::kRenderQuantumFrames * 2));
+ m_downSampler2 =
+ wrapUnique(new DownSampler(AudioUtilities::kRenderQuantumFrames * 4));
}
}
@@ -129,7 +135,7 @@ void WaveShaperDSPKernel::processCurve(const float* source,
void WaveShaperDSPKernel::processCurve2x(const float* source,
float* destination,
size_t framesToProcess) {
- bool isSafe = framesToProcess == RenderingQuantum;
+ bool isSafe = framesToProcess == AudioUtilities::kRenderQuantumFrames;
DCHECK(isSafe);
if (!isSafe)
return;
@@ -147,7 +153,7 @@ void WaveShaperDSPKernel::processCurve2x(const float* source,
void WaveShaperDSPKernel::processCurve4x(const float* source,
float* destination,
size_t framesToProcess) {
- bool isSafe = framesToProcess == RenderingQuantum;
+ bool isSafe = framesToProcess == AudioUtilities::kRenderQuantumFrames;
DCHECK(isSafe);
if (!isSafe)
return;

Powered by Google App Engine
This is Rietveld 408576698