Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 2478283003: Use kRenderQuantumFrames in more places (Closed)

Created:
4 years, 1 month ago by Raymond Toy
Modified:
4 years, 1 month ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews, haraken, Raymond Toy, hongchan
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use kRenderQuantumFrames in more places https://codereview.chromium.org/2440583002/ missed a few places where the constant 128 was definitely referring to the render quantum size. Update the code to use kRenderQuantumFrames. BUG=657620 TEST=none Committed: https://crrev.com/6204f7071ce4b5ee06ba23ba7014f8e09b603ba6 Cr-Commit-Position: refs/heads/master@{#430344}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -40 lines) Patch
M third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp View 5 chunks +9 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/WaveShaperDSPKernel.cpp View 4 chunks +16 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/AudioDestination.cpp View 6 chunks +13 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/HRTFPanner.cpp View 3 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Raymond Toy
PTAL
4 years, 1 month ago (2016-11-04 19:59:20 UTC) #2
hongchan
lgtm
4 years, 1 month ago (2016-11-07 17:01:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2478283003/1
4 years, 1 month ago (2016-11-07 17:46:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-07 19:28:17 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 19:35:19 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6204f7071ce4b5ee06ba23ba7014f8e09b603ba6
Cr-Commit-Position: refs/heads/master@{#430344}

Powered by Google App Engine
This is Rietveld 408576698