Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2478273003: Use overlay scrollbars for the cros system menu. (Closed)

Created:
4 years, 1 month ago by Evan Stade
Modified:
4 years, 1 month ago
Reviewers:
tdanderson, sadrul
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, tfarina, shuchen+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, kalyank, bokan
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use overlay scrollbars for the cros system menu. These scrollbars are already used in the message center. These scrollbars are additionally applied to the CrOS system menu tray detail views (e.g. the list of wifi networks). At a later date, we can enhance these scrollbars (make sure they match Sebastien's specs) and generalize their use to more ChromeOS surfaces. Since it affects layout, we have to carefully make sure not to break anything. Depends on https://codereview.chromium.org/2480763005/ BUG=657159 Committed: https://crrev.com/744d9b779a63b34bce18c0f2ef9206d4565af1ce Cr-Commit-Position: refs/heads/master@{#430619}

Patch Set 1 #

Patch Set 2 : after scrollbar refactor #

Patch Set 3 : rebase #

Total comments: 1

Patch Set 4 : . #

Patch Set 5 : find missing change #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -36 lines) Patch
M ash/common/system/chromeos/ime_menu/ime_menu_tray.cc View 1 2 3 4 5 1 chunk +6 lines, -3 lines 0 comments Download
M ash/common/system/tray/fixed_sized_scroll_view.h View 2 chunks +3 lines, -1 line 0 comments Download
M ash/common/system/tray/fixed_sized_scroll_view.cc View 1 2 3 4 chunks +28 lines, -0 lines 0 comments Download
M ash/common/system/tray/tray_details_view.cc View 1 2 3 4 5 7 chunks +27 lines, -18 lines 0 comments Download
M ui/views/controls/scrollbar/base_scroll_bar.h View 1 2 3 4 2 chunks +0 lines, -5 lines 0 comments Download
M ui/views/controls/scrollbar/overlay_scroll_bar.h View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/controls/scrollbar/overlay_scroll_bar.cc View 1 2 3 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 29 (18 generated)
Evan Stade
4 years, 1 month ago (2016-11-05 01:43:36 UTC) #3
tdanderson
LGTM https://codereview.chromium.org/2478273003/diff/40001/ash/common/system/tray/fixed_sized_scroll_view.cc File ash/common/system/tray/fixed_sized_scroll_view.cc (right): https://codereview.chromium.org/2478273003/diff/40001/ash/common/system/tray/fixed_sized_scroll_view.cc#newcode20 ash/common/system/tray/fixed_sized_scroll_view.cc:20: // for the track, and the track is ...
4 years, 1 month ago (2016-11-07 22:33:21 UTC) #5
Evan Stade
sorry for churn, please re-review. Everything in ime seems to work as it should except ...
4 years, 1 month ago (2016-11-08 00:37:00 UTC) #7
tdanderson
Patch Set 4 LGTM
4 years, 1 month ago (2016-11-08 01:23:39 UTC) #8
Evan Stade
+sadrul for ui/views
4 years, 1 month ago (2016-11-08 01:27:21 UTC) #12
sadrul
lgtm
4 years, 1 month ago (2016-11-08 01:43:24 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2478273003/80001
4 years, 1 month ago (2016-11-08 01:45:37 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/101460) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 1 month ago (2016-11-08 01:49:00 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2478273003/100001
4 years, 1 month ago (2016-11-08 15:07:30 UTC) #25
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 1 month ago (2016-11-08 15:36:30 UTC) #27
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 15:41:58 UTC) #29
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/744d9b779a63b34bce18c0f2ef9206d4565af1ce
Cr-Commit-Position: refs/heads/master@{#430619}

Powered by Google App Engine
This is Rietveld 408576698