Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2478263003: [layoutng] Implement min-/max-content part 2. (Closed)

Created:
4 years, 1 month ago by cbiesinger
Modified:
4 years, 1 month ago
Reviewers:
atotic, eae, cbiesinger1
CC:
atotic+reviews_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, cbiesinger, chromium-reviews, eae+blinkwatch, glebl+reviews_chromium.org, jchaffraix+rendering, leviw+renderwatch, ojan+watch_chromium.org, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[layoutng] Implement min-/max-content part 2. This adds support to ng_length_utils for min/max/fit-content. It does not yet change NGBlockLayoutAlgorithm to compute and pass the values to these functions. However, it does add NeedMinAndMaxContentSizes which the algorithm can use to determine whether it should compute the sizes (this will be a performance optimization that I expect to be very important). R=atotic@chromium.org,eae@chromium.org BUG=635619 Committed: https://crrev.com/820cba16a1d9eb47f80fa916a94372f1542c0c2f Cr-Commit-Position: refs/heads/master@{#430680}

Patch Set 1 #

Total comments: 2

Patch Set 2 : review comment #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -52 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc View 1 2 2 chunks +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_algorithm.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_length_utils.h View 1 2 3 chunks +19 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc View 1 2 6 chunks +78 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc View 1 2 5 chunks +46 lines, -7 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
cbiesinger
4 years, 1 month ago (2016-11-04 21:32:00 UTC) #1
atotic
https://codereview.chromium.org/2478263003/diff/1/third_party/WebKit/Source/core/layout/ng/ng_length_utils.h File third_party/WebKit/Source/core/layout/ng/ng_length_utils.h (right): https://codereview.chromium.org/2478263003/diff/1/third_party/WebKit/Source/core/layout/ng/ng_length_utils.h#newcode40 third_party/WebKit/Source/core/layout/ng/ng_length_utils.h:40: const MinAndMaxContentSizes&, In my code, I made these arguments: ...
4 years, 1 month ago (2016-11-04 21:52:12 UTC) #4
atotic
On 2016/11/04 at 21:52:12, atotic2 wrote: > https://codereview.chromium.org/2478263003/diff/1/third_party/WebKit/Source/core/layout/ng/ng_length_utils.h > File third_party/WebKit/Source/core/layout/ng/ng_length_utils.h (right): > > https://codereview.chromium.org/2478263003/diff/1/third_party/WebKit/Source/core/layout/ng/ng_length_utils.h#newcode40 ...
4 years, 1 month ago (2016-11-04 21:56:13 UTC) #5
cbiesinger
https://codereview.chromium.org/2478263003/diff/1/third_party/WebKit/Source/core/layout/ng/ng_length_utils.h File third_party/WebKit/Source/core/layout/ng/ng_length_utils.h (right): https://codereview.chromium.org/2478263003/diff/1/third_party/WebKit/Source/core/layout/ng/ng_length_utils.h#newcode40 third_party/WebKit/Source/core/layout/ng/ng_length_utils.h:40: const MinAndMaxContentSizes&, On 2016/11/04 21:52:12, atotic2 wrote: > In ...
4 years, 1 month ago (2016-11-04 22:35:24 UTC) #7
eae
LGTM
4 years, 1 month ago (2016-11-08 01:04:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2478263003/20001
4 years, 1 month ago (2016-11-08 01:40:54 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/268136)
4 years, 1 month ago (2016-11-08 01:54:58 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2478263003/40001
4 years, 1 month ago (2016-11-08 18:01:19 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-08 19:15:06 UTC) #19
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 19:39:42 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/820cba16a1d9eb47f80fa916a94372f1542c0c2f
Cr-Commit-Position: refs/heads/master@{#430680}

Powered by Google App Engine
This is Rietveld 408576698