core/fpdfdoc/cpdf_annot.cpp - Issue 2478253002: Revert of Remove CPDF_Object::Release() in favor of direct delete

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfdoc/cpdf_annot.cpp

Issue 2478253002: Revert of Remove CPDF_Object::Release() in favor of direct delete (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfdoc/cpdf_annot.cpp

diff --git a/core/fpdfdoc/cpdf_annot.cpp b/core/fpdfdoc/cpdf_annot.cpp

index 2f3fc804f32015ee484e0c61ab0d3e3a9051a8bc..80edde8a8febf67d92aa2dc42b31e7c927ea5322 100644

--- a/core/fpdfdoc/cpdf_annot.cpp

+++ b/core/fpdfdoc/cpdf_annot.cpp

@@ -57,7 +57,7 @@

CPDF_Annot::~CPDF_Annot() {

if (m_bOwnedAnnotDict)

- delete m_pAnnotDict;

+ m_pAnnotDict->Release();

ClearCachedAP();

}

« no previous file with comments | « core/fpdfapi/parser/cpdf_syntax_parser.cpp ('k') | core/fpdfdoc/cpdf_filespec_unittest.cpp » ('j') | no next file with comments »