chrome/android/java/src/org/chromium/chrome/browser/invalidation/InvalidationController.java - Issue 2478243006: Force sessions invalidations on for Android clients with foreign tabs suggestions feature.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/invalidation/InvalidationController.java

Issue 2478243006: Force sessions invalidations on for Android clients with foreign tabs suggestions feature. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java ('k') | chrome/browser/android/chrome_feature_list.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/invalidation/InvalidationController.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/invalidation/InvalidationController.java b/chrome/android/java/src/org/chromium/chrome/browser/invalidation/InvalidationController.java

index d583b8ed9e52bffad9945547cdba488ee7cd232d..d74996acbe0ea62a3ba2337790d17b3919b09aab 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/invalidation/InvalidationController.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/invalidation/InvalidationController.java

@@ -16,6 +16,7 @@ import org.chromium.base.ApplicationState;

import org.chromium.base.ApplicationStatus;

import org.chromium.base.FieldTrialList;

import org.chromium.base.VisibleForTesting;

+import org.chromium.chrome.browser.ChromeFeatureList;

import org.chromium.chrome.browser.sync.ProfileSyncService;

import org.chromium.components.invalidation.InvalidationClientService;

import org.chromium.components.signin.ChromeSigninController;

@@ -283,7 +284,12 @@ public class InvalidationController implements ApplicationStatus.ApplicationStat

// that local session data is current and can be used to perform checks.

boolean requireInvalidationsForInstrumentation =

FieldTrialList.findFullName("PageRevisitInstrumentation").equals("Enabled");

- boolean canDisableSessionInvalidations = !requireInvalidationsForInstrumentation;

+ // If the NTP is trying to suggest foreign tabs, then recieving invalidations is

+ // vital, otherwise data is stale and less useful.

+ boolean requireInvalidationsForSuggestions = ChromeFeatureList.isEnabled(

+ ChromeFeatureList.NTP_FOREIGN_SESSIONS_SUGGESTIONS);

+ boolean canDisableSessionInvalidations = !requireInvalidationsForInstrumentation

+ && !requireInvalidationsForSuggestions;

boolean canUseGcmUpstream =

FieldTrialList.findFullName("InvalidationsGCMUpstream").equals("Enabled");